Skip to content

fix: fixed Visual Studio setup with fallback windows installation#314

Merged
soumyamahunt merged 3 commits into
mainfrom
winpath
Sep 18, 2024
Merged

fix: fixed Visual Studio setup with fallback windows installation#314
soumyamahunt merged 3 commits into
mainfrom
winpath

Conversation

@soumyamahunt

Copy link
Copy Markdown
Contributor

fixes #313

@codecov

codecov Bot commented Sep 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (32c3196) to head (c21382c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/installer/windows/index.ts 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   92.79%   92.87%   +0.07%     
==========================================
  Files          34       34              
  Lines        1083     1094      +11     
  Branches      157      160       +3     
==========================================
+ Hits         1005     1016      +11     
+ Misses         78       77       -1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soumyamahunt soumyamahunt merged commit f2a737f into main Sep 18, 2024
@soumyamahunt soumyamahunt deleted the winpath branch September 18, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] On Windows this action leaves the wrong link.exe first in the PATH.

1 participant