Replace NETCOREAPP compiler directive with NET (dotnet#101693)

* Replace NETCOREAPP compiler directive with NET

Consistently use the `NET` preprocessor directive
instead of a mix of both `NETCOREAPP` and `NET`.

* Remaining NETCOREAPP usages

* Update TestCaseCompilationMetadataProvider.cs

* Update TestCaseCompilationMetadataProvider.cs

Author: ViktorHofer

src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ILInputCompiler.cs

@@ -45,7 +45,7 @@ protected virtual void SetupProcess (Process process, CompilerOptions options)
 		private static string BuildArguments (CompilerOptions options)
 		{
 			var args = new StringBuilder ();
-#if NETCOREAPP
+#if NET
 			args.Append (options.OutputPath.ExtensionWithDot == ".dll" ? "-dll" : "-exe");
 			args.Append ($" -out:{options.OutputPath.InQuotes ()}");
 #else
@@ -58,7 +58,7 @@ private static string BuildArguments (CompilerOptions options)
 
 		protected virtual NPath LocateIlasm ()
 		{
-#if NETCOREAPP
+#if NET
 			var extension = RuntimeInformation.IsOSPlatform (OSPlatform.Windows) ? ".exe" : "";
 
 			var toolsDir = (string) AppContext.GetData ("Mono.Linker.Tests.ILToolsDir")!;

src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/TestCaseCompilationMetadataProvider.cs

@@ -77,7 +77,7 @@ public virtual IEnumerable<string> GetDefines ()
 				yield return "WIN32";
 
 			if (Characteristics.HasFlag (TestRunCharacteristics.TargetingNetCore))
-				yield return "NETCOREAPP";
+				yield return "NET";
 
 			if (Characteristics.HasFlag (TestRunCharacteristics.SupportsDefaultInterfaceMethods))
 				yield return "SUPPORTS_DEFAULT_INTERFACE_METHODS";

src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/TestCaseCompiler.cs

@@ -9,7 +9,7 @@
 using System.Text;
 using Mono.Linker.Tests.Extensions;
 using Xunit;
-#if NETCOREAPP
+#if NET
 using System.Runtime.InteropServices;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Emit;
@@ -190,7 +190,7 @@ protected static NPath MakeSupportingAssemblyReferencePathAbsolute (NPath output
 			if (Path.IsPathRooted (referenceFileName))
 				return referenceFileName.ToNPath ();
 
-#if NETCOREAPP
+#if NET
 			if (referenceFileName.StartsWith ("System.", StringComparison.Ordinal) ||
 				referenceFileName.StartsWith ("Mono.", StringComparison.Ordinal) ||
 				referenceFileName.StartsWith ("Microsoft.", StringComparison.Ordinal) ||
@@ -224,14 +224,14 @@ protected NPath CompileAssembly (CompilerOptions options)
 
 		protected virtual NPath CompileCSharpAssemblyWithDefaultCompiler (CompilerOptions options)
 		{
-#if NETCOREAPP
+#if NET
 			return CompileCSharpAssemblyWithRoslyn (options);
 #else
 			return CompileCSharpAssemblyWithCsc (options);
 #endif
 		}
 
-#if NETCOREAPP
+#if NET
 		protected virtual NPath CompileCSharpAssemblyWithRoslyn (CompilerOptions options)
 		{
 			var languageVersion = LanguageVersion.Default;
@@ -331,7 +331,7 @@ protected virtual NPath CompileCSharpAssemblyWithRoslyn (CompilerOptions options
 
 		protected virtual NPath CompileCSharpAssemblyWithCsc (CompilerOptions options)
 		{
-#if NETCOREAPP
+#if NET
 			return CompileCSharpAssemblyWithRoslyn (options);
 #else
 			return CompileCSharpAssemblyWithExternalCompiler (LocateCscExecutable (), options, "/shared ");

src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/TrimmingArgumentBuilder.cs

@@ -217,7 +217,7 @@ public virtual void ProcessOptions (TestCaseLinkerOptions options)
 
 			IgnoreLinkAttributes (options.IgnoreLinkAttributes);
 
-#if !NETCOREAPP
+#if !NET
 			if (!string.IsNullOrEmpty (options.Il8n))
 				AddIl8n (options.Il8n);
 #endif

src/libraries/Common/src/Extensions/ChangeCallbackRegistrar.cs

@@ -21,7 +21,7 @@ internal static class ChangeCallbackRegistrar
         /// <returns>The <see cref="CancellationToken"/> registration.</returns>
         internal static IDisposable UnsafeRegisterChangeCallback<T>(Action<object?> callback, object? state, CancellationToken token, Action<T> onFailure, T onFailureState)
         {
-#if NETCOREAPP || NETSTANDARD2_1
+#if NET || NETSTANDARD2_1
             try
             {
                 return token.UnsafeRegister(callback, state);

src/libraries/Common/src/Interop/Windows/NCrypt/Interop.Properties.cs

@@ -56,7 +56,7 @@ internal static unsafe ErrorCode NCryptGetIntProperty(SafeNCryptHandle hObject,
         {
             fixed (int* pResult = &result)
             {
-#if NETSTANDARD || NETCOREAPP
+#if NETSTANDARD || NET
                 Debug.Assert(RuntimeInformation.IsOSPlatform(OSPlatform.Windows));
 #endif
 

src/libraries/Common/src/System/HashCodeRandomization.cs

@@ -16,7 +16,7 @@ internal static class HashCodeRandomization
     {
         public static int GetRandomizedOrdinalHashCode(this string value)
         {
-#if NETCOREAPP
+#if NET
             // In .NET Core, string hash codes are already randomized.
 
             return value.GetHashCode();

src/libraries/Common/src/System/Reflection/AssemblyNameFormatter.cs

@@ -129,7 +129,7 @@ private static void AppendQuoted(this ref ValueStringBuilder vsb, string s)
                 vsb.Append(quoteChar);
         }
 
-#if !NETCOREAPP
+#if !NET
         private static void AppendSpanFormattable(this ref ValueStringBuilder vsb, ushort value)
         {
             vsb.Append(value.ToString());

src/libraries/Common/src/System/Resources/ResourceWriter.cs

@@ -488,7 +488,7 @@ private static ResourceTypeCode FindTypeCode(object? value, List<string> types)
                 if (typeName.StartsWith("ResourceTypeCode.", StringComparison.Ordinal))
                 {
                     typeName = typeName.Substring(17);  // Remove through '.'
-#if NETCOREAPP
+#if NET
                     ResourceTypeCode typeCode = Enum.Parse<ResourceTypeCode>(typeName);
 #else
                     ResourceTypeCode typeCode = (ResourceTypeCode)Enum.Parse(typeof(ResourceTypeCode), typeName);

src/libraries/Common/src/System/Security/Cryptography/Asn1/Pkcs12/PfxAsn.manual.cs

@@ -63,7 +63,7 @@ internal bool VerifyMac(
                 throw new CryptographicException(SR.Cryptography_Der_Invalid_Encoding);
             }
 
-#if NETCOREAPP
+#if NET
             Debug.Assert(expectedOutputSize <= 64); // SHA512 is the largest digest size we know about
             Span<byte> derived = stackalloc byte[expectedOutputSize];
 #else