Skip to content

Add Meteor.js integration support, http://meteor.com - #115

Merged
RubaXa merged 1 commit into
SortableJS:masterfrom
dandv:master
Nov 24, 2014
Merged

Add Meteor.js integration support, http://meteor.com#115
RubaXa merged 1 commit into
SortableJS:masterfrom
dandv:master

Conversation

@dandv

@dandv dandv commented Nov 24, 2014

Copy link
Copy Markdown
Contributor

Hi RubaXa,

I'm a package maintainer for Meteor.js, the most popular full-stack JavaScript framework.

We'd love to have an official integration with Sortable, so I'm submitting this PR so you can directly publish updated versions. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer.

I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions of Sortable, you'll be able to publish them to Atmosphere by running:

meteor/publish.sh

Thanks & best regards,
Dan

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

@dandv alas,

Perhaps I've already created an account, but I do not remember.
Therefore created ibnrubaxa.

@dandv

dandv commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

Ah, that's because I had created the rubaxa organization... Anyway, ibnrubaxa added! You should now be able to publish the package when you release a new version (I had published the current version at https://atmospherejs.com/rubaxa/sortable).

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

Okey.

RubaXa added a commit that referenced this pull request Nov 24, 2014
Add Meteor.js integration support, http://meteor.com
@RubaXa
RubaXa merged commit fad712a into SortableJS:master Nov 24, 2014
@dandv

dandv commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

Congratulations! First popular JS library to officially support Meteor!

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

It's ok?

$ ./meteor/publish.sh
Please log in with your Meteor developer account. If you don't have one, you can quickly create one at www.meteor.com.
Username: ibnrubaxa
Password:
Reading package...
Bundling source...
Creating package version...
Error creating package version: Version already exists

@dandv

dandv commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

This is normal because the version defined in meteor/package.js is the same as the published one, 0.5.2. Right now you only need to publish the package again if you are indeed releasing a new version of Sortable (are you?). If so, then you just need to update the version line in meteor/package.js.

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

@dandv Okey, thank you!

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

Soon there will be a big update (dev-branch):

  • animation
  • group settings
  • support AngularJS (ng-sortable)

@dandv

dandv commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

Bower and Component automatically re-scan the GitHub repo for release tags. But when you finish that update, and you'll publish to npmjs with npm publish, will you remember to publish to Atmosphere with meteor/publish.sh?

Maybe it would help to add a Grunt task to publish to both npmjs and Atmosphere. I would submit a patch but I don't have Grunt experience.

@RubaXa

RubaXa commented Nov 24, 2014

Copy link
Copy Markdown
Collaborator

#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants