[Fix] Sandbox yarn PATH and --no-verify git push delivery - #935
Draft
pridemusvaire wants to merge 4 commits into
Draft
[Fix] Sandbox yarn PATH and --no-verify git push delivery#935pridemusvaire wants to merge 4 commits into
pridemusvaire wants to merge 4 commits into
Conversation
Enable Corepack yarn on the worker PATH and push with --no-verify in delivery skills so husky pre-push suites do not block Roomote sandbox delivery or get misreported as missing GitLab credentials.
Knip flagged them as unlisted after Corepack yarn enablement; they are runtime worker tools, not package dependencies.
Verify yarn with --version after prepare/activate, cover soft-failure paths in tests, and clarify that CI owns secret and policy gates when skills skip pre-push hooks.
pridemusvaire
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 31, 2026 07:08
Contributor
|
No code issues found. See task
Reviewed 92c978c |
pridemusvaire
marked this pull request as draft
July 31, 2026 07:22
…icit Unscoped `corepack enable` also plants pnpm/pnpx shims next to the corepack binary, which the following `mise reshim` would publish ahead of the mise-managed pnpm, so scope it to yarn and bound the registry download that now runs on every cold sandbox boot. The delivery skills justified skipping pre-push by asserting CI and branch protection own the secret and policy gates it skips, which Roomote cannot verify for an arbitrary repository. Replace that with an honest rationale plus a mandatory pre-push secret review, teach agents that a rejection naming a secret is a finding rather than an environment problem to retry around, and lock the whole contract with a prompt-invariant test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Worker setup
corepack enable yarn+corepack prepare yarn@stable --activate+mise reshim) and verifies withyarn --version, so hooks that shell out to yarn no longer fail withyarn: not found.enableis scoped to yarn deliberately: the unscoped form also writespnpm/pnpxshims next to the corepack binary, which the following reshim would publish ahead of the mise-managed pnpm.Delivery skills
--no-verify. Local pre-push hooks re-run full lint/typecheck/test suites against host tooling the sandbox does not have, which produces false delivery failures that agents misreport as missing Git credentials.GH013) is a real finding to report and fix, never something to retry around with--no-verify.--no-verifycannot generalise from pushes to commits.Why this change was made
Sandbox pushes failed when a pre-push hook ran
yarnthat was not on PATH, and agents narrated that as a Git credentials problem. Local pre-push suites also differ from developer machines and false-block delivery.Impact
New tasks get yarn on PATH during worker setup, and agents deliver without running sandbox-hostile pre-push hooks. In exchange the agent, not an assumed CI job, owns the secret check before every push.
Test plan
apps/workermise setup tests: 14 passing (was 7 before this branch)packages/cloud-agentsworkflow tests: 287 passing across 45 files, including a new prompt-invariant test that locks the push contract across all six delivery skillscorepack enable, a removed timeout,?? 1→?? 0,mise reshim <tool>, a swallowed warning, a secret review moved after the push, an opt-out clause, a reintroduced CI-owns-the-gates claim, a push demoted to a fenced block, and an inverted error classification all turn the suites redpnpm knip,oxlint,oxfmt --check, andtsc --noEmitclean in both packages