php-in-php: arrow-function overlay + enum parity compliance PHPTs - #8557
Merged
Merged
Conversation
Early overlay for resolveOp_Expr_ArrowFunction unblocks fn() callbacks in compiled PHP (array_find family JIT/VM) when later php-types patches fail. Add php-src-strict compliance PHPTs for lcfirst/fwrite/filter_var enum guards. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_php_types_arrow_function_overlay()and invoke it early inscript/apply-patches.shsoresolveOp_Expr_ArrowFunctionlands even when later php-types patches fail (unblocksfn()in compiled PHP — array_find family, closure callbacks).apply_patch()dispatch +verify_critical_language_patchesguard.lcfirst,fwritedata,filter_varFILTER_VALIDATE_INT.php-src reference
vendor/ircmaxell/php-typesTypeReconstructor — arrow-function op typing (pairs php-cfgparseExpr_ArrowFunction)ext/standard/string.c(lcfirst),ext/standard/streamsfuncs.c(fwrite),ext/filter/filter.c(filter_var)C runtime shrink
No
runtime/changes (onlylib/AOT/runtime/phpc_progress.cremains per #5211).Verification
Closes #6003 (compliance coverage). Related: #5945, #5796 (PHPTs added; behavior already green).
Made with Cursor