fix(agent): don't fail a successful run on a post-completion socket close#662
Merged
Merged
Conversation
…lose The Claude SDK can emit a second error result during teardown carrying "API Error: The socket connection was closed unexpectedly". Its text landed in the output signals, so the post-loop hasApiError() check escalated teardown noise to a fatal API_ERROR and aborted an otherwise successful run. Short-circuit to success once a clean result has arrived, mirroring the existing catch-path guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a really weird bug we can sometimes have with the Claude agent sdk where it errors on the teardown after succeeding
posthog-wizard (4).log
this hopefully fixes it. Doesn't affect prod, only CI mode