Skip to content

feat: Slack connect follow-ups from #640 review#648

Merged
gewenyu99 merged 3 commits into
mainfrom
feat/slack-connect-follow-ups
Jun 12, 2026
Merged

feat: Slack connect follow-ups from #640 review#648
gewenyu99 merged 3 commits into
mainfrom
feat/slack-connect-follow-ups

Conversation

@gewenyu99

Copy link
Copy Markdown
Collaborator

Follow-ups to #640. I merged that PR before this work was pushed, my mistake — the review fixes and everything below were sitting uncommitted in a local worktree while the original branch went in.

What this adds on top of #640:

  • Addresses my own review comments: drops the probe timeout, requests integration:read, captures check failures to error tracking, removes the JSON note keys in favor of real comments.
  • Auth runs up front in the MCP tutorial so the first screen already knows the Slack state. Esc cancels back to Choose.
  • slackConnected lives in the session, checked once per flow. The Connect-Slack screen seeds from it (no nudge flash) and polls every 3s while open, tearing down timers and in-flight requests on exit.
  • PickerMenu supports disabled options with an icon slot. Navigation skips them, focus revalidates when options change. Connected state renders as a green ✔ "Already connected to Slack".
  • The main wizard gets the Connect-Slack step between MCP and outro — always shown, declinable.
  • The Goodbye card no longer duplicates the Slack card the dedicated step shows right after.
  • Ctrl+C exits cleanly: no more read EIO stack, no zombie process holding the OAuth callback server.
  • Health checks only fire for programs that declare a health-check screen, and onInit hooks fire when the TUI renders rather than at store construction — tests and the playground no longer hit real status endpoints.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🧙 Wizard CI

Run the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands:

Test all apps:

  • /wizard-ci all

Test all apps in a directory:

  • /wizard-ci basic-integration
  • /wizard-ci error-tracking-upload-source-maps
  • /wizard-ci misc
  • /wizard-ci revenue

Test an individual app:

  • /wizard-ci basic-integration/android
  • /wizard-ci basic-integration/angular
  • /wizard-ci basic-integration/astro
Show more apps
  • /wizard-ci basic-integration/django
  • /wizard-ci basic-integration/fastapi
  • /wizard-ci basic-integration/flask
  • /wizard-ci basic-integration/javascript-node
  • /wizard-ci basic-integration/javascript-web
  • /wizard-ci basic-integration/laravel
  • /wizard-ci basic-integration/next-js
  • /wizard-ci basic-integration/nuxt
  • /wizard-ci basic-integration/python
  • /wizard-ci basic-integration/rails
  • /wizard-ci basic-integration/react-native
  • /wizard-ci basic-integration/react-router
  • /wizard-ci basic-integration/sveltekit
  • /wizard-ci basic-integration/swift
  • /wizard-ci basic-integration/tanstack-router
  • /wizard-ci basic-integration/tanstack-start
  • /wizard-ci basic-integration/vue
  • /wizard-ci error-tracking-upload-source-maps/android
  • /wizard-ci error-tracking-upload-source-maps/flutter
  • /wizard-ci error-tracking-upload-source-maps/ios
  • /wizard-ci error-tracking-upload-source-maps/next
  • /wizard-ci error-tracking-upload-source-maps/next-no-posthog
  • /wizard-ci error-tracking-upload-source-maps/node-raw
  • /wizard-ci error-tracking-upload-source-maps/node-rollup
  • /wizard-ci error-tracking-upload-source-maps/node-rollup-typescript-plugin
  • /wizard-ci error-tracking-upload-source-maps/node-webpack
  • /wizard-ci error-tracking-upload-source-maps/nuxt-3-6
  • /wizard-ci error-tracking-upload-source-maps/nuxt-4-3
  • /wizard-ci error-tracking-upload-source-maps/react-native
  • /wizard-ci error-tracking-upload-source-maps/react-vite
  • /wizard-ci error-tracking-upload-source-maps/rust
  • /wizard-ci misc/quack-quack
  • /wizard-ci revenue/stripe

Results will be posted here when complete.

Comment thread src/lib/mcp-role-prompts.copy.json
@gewenyu99 gewenyu99 requested a review from sarahxsanders June 12, 2026 00:49

@sarahxsanders sarahxsanders left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted one thing with the picker menu then you're good to go

Comment thread src/ui/tui/primitives/PickerMenu.tsx Outdated
Comment thread src/ui/tui/primitives/PickerMenu.tsx Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gewenyu99 gewenyu99 enabled auto-merge (squash) June 12, 2026 01:00
@gewenyu99 gewenyu99 merged commit f5a6f72 into main Jun 12, 2026
17 checks passed
@gewenyu99 gewenyu99 deleted the feat/slack-connect-follow-ups branch June 12, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants