You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f3116ff
Browse filesBrowse the repository at this point in the historyBrowse files
fix(mcp): reword injected descriptions so directory review stops flagging them (#1191)
* fix(mcp): reword injected argument descriptions for directory review
What: reworded the descriptions of the injected conversation_id and llm_model
arguments and the get_more_tools and send_feedback virtual tools (plus the
feedback_type property) so each states what the field is and that it is
recorded for analytics. Removed behavioral instructions and broad-triggering
lines. Descriptions only: names, annotations, schemas and the canned
get_more_tools reply are unchanged. Adds a patch sampo changeset.
Why: the ChatGPT and Claude directory reviews flag descriptions that tell the
model how to behave beyond one call or ask to be triggered broadly.
Tests:
- pytest posthog/test/mcp (PYTHONPATH=worktree): 665 passed, 10 skipped
- new parameterized test_advertised_descriptions_carry_no_behavioral_instructions
failed 6/6 on the old text, passes now
- ruff format --check / ruff check on posthog/mcp and posthog/test/mcp: clean
Reviewer note: test_units asserted the old conversation_id clause "rest of the
conversation, including after later user messages"; its comment says ChatGPT
drops the handle without it. The new wording drops that clause as specified, so
session continuity on ChatGPT is worth watching.
* fix(mcp): keep the cross-message clause in the conversation_id description
posthog-js#5112 added "for the rest of the conversation, including after
later user messages" because ChatGPT otherwise drops the handle on the
first call of each new user message. Keep that semantics; it describes
the field, not unrelated model behaviour. The parallel-calls and
different-task instructions stay out.
Reworded the descriptions of the injected `conversation_id` and `llm_model` arguments and the `get_more_tools` and `send_feedback` virtual tools so they describe the field instead of instructing the model. This changes your published tool definitions; if your server is listed in the ChatGPT or Claude directories, those platforms may re-review the updated tools.
0 commit comments