Skip to content

Commit d320c2e

Browse files
authored
FIX: broken tests after changing default boss preset (#8327)
Due to #8271 changing the default boss preset many tests that relied on enemy stats broke. This pr fixes that by changing the boss configuration back to "None" for affected tests. Additionally this commit adds an extra test for scorching ray exposure when using the automatic maximum sustainable stages mode.
1 parent 239aeb2 commit d320c2e

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

spec/System/TestDefence_spec.lua

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ describe("TestDefence", function()
99

1010
-- boring part
1111
it("no armour max hits", function()
12+
build.configTab.input.enemyIsBoss = "None"
13+
build.configTab:BuildModList()
14+
runCallback("OnFrame")
15+
1216
assert.are.equals(60, build.calcsTab.calcsOutput.PhysicalMaximumHitTaken)
1317
assert.are.equals(38, build.calcsTab.calcsOutput.FireMaximumHitTaken)
1418
assert.are.equals(38, build.calcsTab.calcsOutput.ColdMaximumHitTaken)
@@ -19,6 +23,7 @@ describe("TestDefence", function()
1923
+200 to all resistances\n\z
2024
200% additional Physical Damage Reduction\n\z
2125
"
26+
2227
build.configTab:BuildModList()
2328
runCallback("OnFrame")
2429
assert.are.equals(600, build.calcsTab.calcsOutput.PhysicalMaximumHitTaken)
@@ -168,6 +173,7 @@ describe("TestDefence", function()
168173
When Hit during effect, 50% of Life loss from Damage taken occurs over 4 seconds instead\n\z
169174
" -- 50% progenesis should just simply double the life pool
170175
build.configTab.input.conditionUsingFlask = true
176+
build.configTab.input.enemyIsBoss = "None"
171177
build.configTab:BuildModList()
172178
runCallback("OnFrame")
173179
assert.are.equals(600, build.calcsTab.calcsOutput.PhysicalMaximumHitTaken)
@@ -186,7 +192,6 @@ describe("TestDefence", function()
186192
100% less intelligence\n\z
187193
+60 to maximum energy shield\n\z
188194
" -- progenesis should not interact with pools other than life.
189-
build.configTab.input.conditionUsingFlask = true
190195
build.configTab:BuildModList()
191196
runCallback("OnFrame")
192197
assert.are.equals(900, build.calcsTab.calcsOutput.PhysicalMaximumHitTaken)
@@ -257,7 +262,6 @@ describe("TestDefence", function()
257262
100% less intelligence\n\z
258263
+60 to maximum energy shield\n\z
259264
" -- wonkier numbers to test the pool reduction function
260-
build.configTab.input.conditionUsingFlask = true
261265
build.configTab:BuildModList()
262266
runCallback("OnFrame")
263267
assert.are.equals(1300, build.calcsTab.calcsOutput.PhysicalMaximumHitTaken)
@@ -323,6 +327,7 @@ describe("TestDefence", function()
323327
+940 to maximum life\n\z
324328
+10000 to armour\n\z
325329
" -- hit of 2000 on 10000 armour results in 50% DR which reduces the damage to 1000 - total HP
330+
build.configTab.input.enemyIsBoss = "None"
326331
build.configTab:BuildModList()
327332
runCallback("OnFrame")
328333
assert.are.equals(1000, takenHitFromTypeMaxHit("Physical"))
@@ -603,6 +608,7 @@ describe("TestDefence", function()
603608
end)
604609

605610
it("energy shield bypass tests #pet", function()
611+
build.configTab.input.enemyIsBoss = "None"
606612
-- Mastery
607613
build.configTab.input.customMods = [[
608614
+40 to maximum life
@@ -611,6 +617,7 @@ describe("TestDefence", function()
611617
You have no intelligence
612618
+60% to all resistances
613619
]]
620+
614621
build.configTab:BuildModList()
615622
runCallback("OnFrame")
616623
assert.are.equals(300, build.calcsTab.calcsOutput.FireMaximumHitTaken)

spec/System/TestSkills_spec.lua

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,17 @@ describe("TestAttacks", function()
8686
srcInstance.skillStageCount = 8
8787
build.modFlag = true
8888
build.buildFlag = true
89+
build.configTab.input.enemyIsBoss = "None"
90+
build.configTab:BuildModList()
8991
runCallback("OnFrame")
90-
92+
-- Manual stages
93+
assert.True(build.calcsTab.mainEnv.enemyDB:Sum("BASE", nil, "FireResist") < 0)
94+
95+
srcInstance.skillPart = 2
96+
build.modFlag = true
97+
build.buildFlag = true
98+
runCallback("OnFrame")
99+
-- Automatic maximum sustainable stages
91100
assert.True(build.calcsTab.mainEnv.enemyDB:Sum("BASE", nil, "FireResist") < 0)
92101
end)
93102

0 commit comments

Comments
 (0)