You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix "Farewell to Flesh" not applying to Agony Crawler ailment damage (#9162)
The `GetStat` code relied on using `cfg.summonSkillName` to match names for the skills but when we handle the ailments we were not including summonSkillName in the cfg so it would fail to match and not grant Ailment damage to Agony Crawler
Also added a floor to the returned value as it was a float before
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Copy file name to clipboardExpand all lines: src/Classes/ModStore.lua
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -251,7 +251,7 @@ function ModStoreClass:GetStat(stat, cfg)
251
251
for_, activeSkillinipairs(self.actor.activeSkillList) do
252
252
if (activeSkill.skillTypes[SkillType.HasReservation] andnotactiveSkill.skillFlags.disableandactiveSkill.buffListandactiveSkill.buffList[1] andcfgand (isNameInBuffList(activeSkill.buffList, cfg.skillName) orisNameInBuffList(activeSkill.buffList, cfg.summonSkillName)) ) then
@@ -265,7 +265,7 @@ function ModStoreClass:GetStat(stat, cfg)
265
265
for_, activeSkillinipairs(self.actor.activeSkillList) do
266
266
if (activeSkill.skillTypes[SkillType.HasReservation] andnotactiveSkill.skillFlags.disableandactiveSkill.buffListandactiveSkill.buffList[1] andcfgand (isNameInBuffList(activeSkill.buffList, cfg.skillName) orisNameInBuffList(activeSkill.buffList, cfg.summonSkillName)) ) then
Copy file name to clipboardExpand all lines: src/Modules/ModParser.lua
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -2858,7 +2858,7 @@ local specialModList = {
2858
2858
["herald skills and minions from herald skills deal (%d+)%% more damage for every (%d+)%% of maximum life those skills reserve"] = function(_, num1, num2) return {
2859
2859
mod("MinionModifier", "LIST", { mod = mod("Damage", "MORE", tonumber(num1), { type = "PerStat", stat = "LifeReservedPercent", div = tonumber(num2), actor = "parent" })}, { type = "SkillType", skillType = SkillType.Herald }),
2860
2860
mod("Damage", "MORE", tonumber(num1), { type = "PerStat", stat = "LifeReservedPercent", div = tonumber(num2) }, { type = "SkillType", skillType = SkillType.Herald }),
2861
-
} end,
2861
+
} end,
2862
2862
-- Oshabi Bloodline
2863
2863
["unsealed spells gain (%d+)%% more damage each time their effects reoccur"] = function(num) return { mod("MaxSealDamage", "MORE", num) } end,
2864
2864
["skills gain added chaos damage equal to (%d+)%% of life cost, if life cost is not higher than the maximum you could spend"] = function(num) return {
0 commit comments