From d054648f8d45027bd18117180be91bd7a353c904 Mon Sep 17 00:00:00 2001 From: AviPeltz Date: Wed, 22 Jul 2026 02:03:34 -0700 Subject: [PATCH] fix(desktop): remove browser pane tooltips and restyle pane/preset tooltips Remove tooltips from browser back/forward/reload buttons and the shared close-pane button (v1 + v2). Restyle the split-pane and Manage Presets tooltips to the subtle hotkey-chip style with a 1s hover delay. Claude-Session: https://claude.ai/code/session_01CxPkcBBWZeaNygsF9dwMCH --- .../components/V2PresetsBar/V2PresetsBar.tsx | 9 ++- .../useDefaultPaneActions.tsx | 1 - .../BrowserToolbar/BrowserToolbar.tsx | 76 +++++++------------ .../TabView/BrowserPane/BrowserPane.tsx | 1 - .../BrowserToolbar/BrowserToolbar.tsx | 76 +++++++------------ .../TabsContent/TabView/ChatPane/ChatPane.tsx | 1 - .../TabView/CommentPane/CommentPane.tsx | 1 - .../TabView/DevToolsPane/DevToolsPane.tsx | 1 - .../TabsContent/TabView/TabPane.tsx | 1 - .../PaneToolbarActions/PaneToolbarActions.tsx | 34 ++++----- .../components/PresetsBar/PresetsBar.tsx | 9 ++- .../PaneHeaderActions/PaneHeaderActions.tsx | 34 ++++++--- packages/panes/src/react/types.ts | 2 +- 13 files changed, 106 insertions(+), 140 deletions(-) diff --git a/apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/V2PresetsBar/V2PresetsBar.tsx b/apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/V2PresetsBar/V2PresetsBar.tsx index e0c521d2c8f..3ae565b8d19 100644 --- a/apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/V2PresetsBar/V2PresetsBar.tsx +++ b/apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/V2PresetsBar/V2PresetsBar.tsx @@ -198,7 +198,7 @@ export function V2PresetsBar({ style={{ scrollbarWidth: "none" }} > - + - - - Go Back - - - - - - - - Go Forward - - - - - - - - {isLoading ? "Loading..." : "Reload"} - - + + +
diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsx index 0225544e8bb..0fce8d06af7 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/BrowserPane.tsx @@ -89,7 +89,6 @@ export function BrowserPane({ splitOrientation={handlers.splitOrientation} onSplitPane={handlers.onSplitPane} onClosePane={handlers.onClosePane} - closeHotkeyId="CLOSE_TERMINAL" leadingActions={ <> diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx index 32c37a39a0e..0c155fb9f18 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/BrowserPane/components/BrowserToolbar/BrowserToolbar.tsx @@ -1,4 +1,3 @@ -import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip"; import { useCallback, useEffect, useRef, useState } from "react"; import { TbArrowLeft, @@ -114,54 +113,33 @@ export function BrowserToolbar({ return (
- - - - - - Go Back - - - - - - - - Go Forward - - - - - - - - {isLoading ? "Loading..." : "Reload"} - - + + +
diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx index 05e0e6a7b65..9c9b74c360e 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx @@ -155,7 +155,6 @@ export function ChatPane({ splitOrientation={handlers.splitOrientation} onSplitPane={handlers.onSplitPane} onClosePane={handlers.onClosePane} - closeHotkeyId="CLOSE_TERMINAL" />
)} diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsx index 2a3dace7ce6..61b4ad71406 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/CommentPane/CommentPane.tsx @@ -128,7 +128,6 @@ export function CommentPane({ splitOrientation={handlers.splitOrientation} onSplitPane={handlers.onSplitPane} onClosePane={handlers.onClosePane} - closeHotkeyId="CLOSE_TERMINAL" />
)} diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsx index 36d7d4eb015..ce3e7568818 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/DevToolsPane/DevToolsPane.tsx @@ -51,7 +51,6 @@ export function DevToolsPane({ splitOrientation={handlers.splitOrientation} onSplitPane={handlers.onSplitPane} onClosePane={handlers.onClosePane} - closeHotkeyId="CLOSE_TERMINAL" />
)} diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx index 81658904d46..fca9c6ac2fa 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx @@ -122,7 +122,6 @@ export function TabPane({ splitOrientation={handlers.splitOrientation} onSplitPane={handlers.onSplitPane} onClosePane={handlers.onClosePane} - closeHotkeyId="CLOSE_TERMINAL" />
)} diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx index 5fb46c9d1f8..cab18270dea 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/components/PaneToolbarActions/PaneToolbarActions.tsx @@ -1,7 +1,6 @@ import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip"; import { HiMiniXMark } from "react-icons/hi2"; import { TbLayoutColumns, TbLayoutRows } from "react-icons/tb"; -import type { HotkeyId } from "renderer/hotkeys"; import { HotkeyLabel } from "renderer/hotkeys"; import type { SplitOrientation } from "../../hooks"; @@ -10,8 +9,6 @@ interface PaneToolbarActionsProps { onSplitPane: (e: React.MouseEvent) => void; onClosePane: (e: React.MouseEvent) => void; leadingActions?: React.ReactNode; - /** Hotkey ID to display for the close action. Defaults to CLOSE_PANE. */ - closeHotkeyId?: HotkeyId; } export function PaneToolbarActions({ @@ -19,7 +16,6 @@ export function PaneToolbarActions({ onSplitPane, onClosePane, leadingActions, - closeHotkeyId = "CLOSE_PANE", }: PaneToolbarActionsProps) { const splitIcon = splitOrientation === "vertical" ? ( @@ -31,7 +27,7 @@ export function PaneToolbarActions({ return (
{leadingActions} - + - - - - - +
); } diff --git a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/components/PresetsBar/PresetsBar.tsx b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/components/PresetsBar/PresetsBar.tsx index 72a6e2d8dc3..9e8ef463873 100644 --- a/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/components/PresetsBar/PresetsBar.tsx +++ b/apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/components/PresetsBar/PresetsBar.tsx @@ -343,7 +343,7 @@ export function PresetsBar() { style={{ scrollbarWidth: "none" }} > - + - + Manage Presets diff --git a/packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx b/packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx index 70368b89930..ef4c13af591 100644 --- a/packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx +++ b/packages/panes/src/react/components/PaneHeaderActions/PaneHeaderActions.tsx @@ -1,4 +1,5 @@ import { Tooltip, TooltipContent, TooltipTrigger } from "@superset/ui/tooltip"; +import { Fragment } from "react"; import type { PaneActionConfig, RendererContext } from "../../types"; export function PaneHeaderActions({ @@ -24,18 +25,29 @@ export function PaneHeaderActions({ ? action.tooltip(context) : action.tooltip; + const button = ( + + ); + + if (tooltip == null) { + return {button}; + } + return ( - - - - - + + {button} + {tooltip} diff --git a/packages/panes/src/react/types.ts b/packages/panes/src/react/types.ts index 153680d7519..6f0b0dd9b4e 100644 --- a/packages/panes/src/react/types.ts +++ b/packages/panes/src/react/types.ts @@ -6,7 +6,7 @@ import type { Pane, Tab } from "../types"; export interface PaneActionConfig { key: string; icon: ReactNode | ((context: RendererContext) => ReactNode); - tooltip: ReactNode | ((context: RendererContext) => ReactNode); + tooltip?: ReactNode | ((context: RendererContext) => ReactNode); onClick: (context: RendererContext) => void; }