From 80fbcf884e9f770e682505dc54392c3d0b6f976c Mon Sep 17 00:00:00 2001 From: gouzi <530971494@qq.com> Date: Fri, 24 Mar 2023 22:32:04 +0800 Subject: [PATCH 1/2] [CodeStyle][B020] rename for --- pyproject.toml | 2 +- python/paddle/distributed/auto_parallel/engine.py | 8 ++++---- python/paddle/fluid/tests/unittests/eager_op_test.py | 6 +++--- python/paddle/fluid/tests/unittests/op_test.py | 6 +++--- test/legacy_test/test_progressbar.py | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 90c77878cd5266..9e406c8e8095c5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -102,7 +102,7 @@ select = [ # "B017", "B018", "B019", - # "B020", + "B020", "B021", "B022", # "B023", diff --git a/python/paddle/distributed/auto_parallel/engine.py b/python/paddle/distributed/auto_parallel/engine.py index d3c8d68e285556..56cb85f580b4b4 100644 --- a/python/paddle/distributed/auto_parallel/engine.py +++ b/python/paddle/distributed/auto_parallel/engine.py @@ -385,13 +385,13 @@ def _prepare_feed(self, data, user_feeds, mode): if data is not None: if isinstance(data, (list, tuple)): if len(data) == 1 and isinstance(data[0], dict): - for name, data in data[0].items(): - feeds[name] = data + for name, value in data[0].items(): + feeds[name] = value else: raise ValueError("Unsupported data {}".format(data)) elif isinstance(data, dict): - for name, data in data.items(): - feeds[name] = data + for name, value in data.items(): + feeds[name] = value else: raise ValueError("Unsupported data {}".format(data)) if user_feeds is not None: diff --git a/python/paddle/fluid/tests/unittests/eager_op_test.py b/python/paddle/fluid/tests/unittests/eager_op_test.py index acdc87827f6aad..7871938d507400 100644 --- a/python/paddle/fluid/tests/unittests/eager_op_test.py +++ b/python/paddle/fluid/tests/unittests/eager_op_test.py @@ -842,17 +842,17 @@ def create_var( ), "Duplicable {} should be set as list".format(name) var_list = [] slot_name = name - for (name, np_value) in np_list[name]: + for (np_key, np_value) in np_list[name]: v = create_var( np_value, - name, + np_key, is_input, if_return_inputs_grad_dict, self.is_calc_ref, ) var_list.append(v) if if_return_inputs_grad_dict: - inputs_grad_dict[name] = v + inputs_grad_dict[np_key] = v var_dict[slot_name] = var_list else: nplist_value_temp = None diff --git a/python/paddle/fluid/tests/unittests/op_test.py b/python/paddle/fluid/tests/unittests/op_test.py index 147970452abba6..6256169c06d09c 100644 --- a/python/paddle/fluid/tests/unittests/op_test.py +++ b/python/paddle/fluid/tests/unittests/op_test.py @@ -845,17 +845,17 @@ def create_var( ), "Duplicable {} should be set as list".format(name) var_list = [] slot_name = name - for (name, np_value) in np_list[name]: + for (np_key, np_value) in np_list[name]: v = create_var( np_value, - name, + np_key, is_input, if_return_inputs_grad_dict, self.is_calc_ref, ) var_list.append(v) if if_return_inputs_grad_dict: - inputs_grad_dict[name] = v + inputs_grad_dict[np_key] = v var_dict[slot_name] = var_list else: nplist_value_temp = None diff --git a/test/legacy_test/test_progressbar.py b/test/legacy_test/test_progressbar.py index ab562fa49e8cd7..af57c3f00588be 100644 --- a/test/legacy_test/test_progressbar.py +++ b/test/legacy_test/test_progressbar.py @@ -23,7 +23,7 @@ class TestProgressBar(unittest.TestCase): def prog_bar(self, num, epoch, width, verbose=1): - for epoch in range(epoch): + for i in range(epoch): progbar = ProgressBar(num, verbose=verbose) values = [ ['loss', 50.341673], From 02630963e7ee30994e27f2e48304d663e28f475f Mon Sep 17 00:00:00 2001 From: gouzi <530971494@qq.com> Date: Sun, 26 Mar 2023 01:34:10 +0800 Subject: [PATCH 2/2] [CodeStyle][B020] rename for --- python/paddle/fluid/tests/unittests/eager_op_test.py | 6 +++--- python/paddle/fluid/tests/unittests/op_test.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/python/paddle/fluid/tests/unittests/eager_op_test.py b/python/paddle/fluid/tests/unittests/eager_op_test.py index 7871938d507400..19dc953c3bd0bf 100644 --- a/python/paddle/fluid/tests/unittests/eager_op_test.py +++ b/python/paddle/fluid/tests/unittests/eager_op_test.py @@ -842,17 +842,17 @@ def create_var( ), "Duplicable {} should be set as list".format(name) var_list = [] slot_name = name - for (np_key, np_value) in np_list[name]: + for (name, np_value) in np_list[slot_name]: v = create_var( np_value, - np_key, + name, is_input, if_return_inputs_grad_dict, self.is_calc_ref, ) var_list.append(v) if if_return_inputs_grad_dict: - inputs_grad_dict[np_key] = v + inputs_grad_dict[name] = v var_dict[slot_name] = var_list else: nplist_value_temp = None diff --git a/python/paddle/fluid/tests/unittests/op_test.py b/python/paddle/fluid/tests/unittests/op_test.py index 6256169c06d09c..967dd7e65010d6 100644 --- a/python/paddle/fluid/tests/unittests/op_test.py +++ b/python/paddle/fluid/tests/unittests/op_test.py @@ -845,17 +845,17 @@ def create_var( ), "Duplicable {} should be set as list".format(name) var_list = [] slot_name = name - for (np_key, np_value) in np_list[name]: + for (name, np_value) in np_list[slot_name]: v = create_var( np_value, - np_key, + name, is_input, if_return_inputs_grad_dict, self.is_calc_ref, ) var_list.append(v) if if_return_inputs_grad_dict: - inputs_grad_dict[np_key] = v + inputs_grad_dict[name] = v var_dict[slot_name] = var_list else: nplist_value_temp = None