This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Missing macro wrapper for zip_function#1715
Merged
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
okay to test |
jrhemstad
added
P1: should have
Collaborator
|
ok to test |
jrhemstad
added
the
type: cleanup
Collaborator
|
run tests |
alliepiper
approved these changes
Jun 22, 2022
alliepiper
left a comment
alliepiper
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thrust::make_zip_function didn't work with device c++ lambdas as input, this patch suggested by @jrhemstad adds the macro wrapper
__thrust_exec_check_disable__to fix it.