Skip to content

Commit 6fc306f

Browse files
coryrylancoryrylan
committed
chore(ci): lint corrections for missing nve-logo content
Signed-off-by: Cory Rylan <crylan@nvidia.com>
1 parent d61ec17 commit 6fc306f

24 files changed

Lines changed: 35 additions & 35 deletions

File tree

‎projects/core/src/logo/logo.examples.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default {
1414
*/
1515
export const Default = {
1616
render: () => html`
17-
<nve-logo aria-label="NVIDIA"></nve-logo>
17+
<nve-logo aria-label="NVIDIA">NV</nve-logo>
1818
`
1919
};
2020

@@ -67,7 +67,7 @@ export const SlottedIcons = {
6767
export const Color = {
6868
render: () => html`
6969
<div nve-layout="row gap:xs align:wrap">
70-
<nve-logo aria-label="NVIDIA"></nve-logo>
70+
<nve-logo aria-label="NVIDIA">NV</nve-logo>
7171
<nve-logo color="red-cardinal" aria-label="red cardinal">Rc</nve-logo>
7272
<nve-logo color="gray-slate" aria-label="gray slate">Gs</nve-logo>
7373
<nve-logo color="gray-denim" aria-label="gray denim">Gd</nve-logo>
@@ -101,7 +101,7 @@ export const Color = {
101101
export const LightTheme = {
102102
render: () => html`
103103
<div nve-theme="root light" nve-layout="row gap:xs align:wrap pad:sm" style="background: var(--nve-sys-layer-container-background) !important;">
104-
<nve-logo aria-label="NVIDIA"></nve-logo>
104+
<nve-logo aria-label="NVIDIA">NV</nve-logo>
105105
<nve-logo color="red-cardinal" aria-label="red cardinal">Rc</nve-logo>
106106
<nve-logo color="gray-slate" aria-label="gray slate">Gs</nve-logo>
107107
<nve-logo color="gray-denim" aria-label="gray denim">Gd</nve-logo>
@@ -135,7 +135,7 @@ export const LightTheme = {
135135
export const DarkTheme = {
136136
render: () => html`
137137
<div nve-theme="root dark" nve-layout="row gap:xs align:wrap pad:sm">
138-
<nve-logo aria-label="NVIDIA"></nve-logo>
138+
<nve-logo aria-label="NVIDIA">NV</nve-logo>
139139
<nve-logo color="red-cardinal" aria-label="red cardinal">Rc</nve-logo>
140140
<nve-logo color="gray-slate" aria-label="gray slate">Gs</nve-logo>
141141
<nve-logo color="gray-denim" aria-label="gray denim">Gd</nve-logo>

‎projects/core/src/logo/logo.test.axe.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe(Logo.metadata.tag, () => {
1414

1515
beforeEach(async () => {
1616
fixture = await createFixture(html`
17-
<nve-logo aria-label="logo"></nve-logo>
17+
<nve-logo aria-label="logo" color="brand-green">NV</nve-logo>
1818
`);
1919
element = fixture.querySelector(Logo.metadata.tag);
2020
await elementIsStable(element);

‎projects/core/src/logo/logo.test.lighthouse.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { lighthouseRunner } from '@internals/vite';
77
describe('logo lighthouse report', () => {
88
test('logo should meet lighthouse benchmarks', async () => {
99
const report = await lighthouseRunner.getReport('nve-logo', /* html */`
10-
<nve-logo aria-label="logo"></nve-logo>
10+
<nve-logo aria-label="logo">NV</nve-logo>
1111
<script type="module">
1212
import '@nvidia-elements/core/logo/define.js';
1313
</script>

‎projects/core/src/logo/logo.test.ssr.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import '@nvidia-elements/core/logo/define.js';
99

1010
describe(Logo.metadata.tag, () => {
1111
it('should pass baseline ssr check', async () => {
12-
const result = await ssrRunner.render(html`<nve-logo></nve-logo>`);
12+
const result = await ssrRunner.render(html`<nve-logo>NV</nve-logo>`);
1313
expect(result.includes('shadowroot="open"')).toBe(true);
1414
expect(result.includes('nve-logo')).toBe(true);
1515
});

‎projects/core/src/logo/logo.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe(Logo.metadata.tag, () => {
1313

1414
beforeEach(async () => {
1515
fixture = await createFixture(html`
16-
<nve-logo></nve-logo>
16+
<nve-logo>NV</nve-logo>
1717
`);
1818
element = fixture.querySelector(Logo.metadata.tag);
1919
await elementIsStable(element);

‎projects/core/src/menu/menu.examples.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export const Complex = {
188188
</nve-menu-item>
189189
<nve-divider></nve-divider>
190190
<nve-menu-item>
191-
<nve-logo size="sm"></nve-logo> All Apps
191+
<nve-logo size="sm">NV</nve-logo> All Apps
192192
</nve-menu-item>
193193
</nve-menu>
194194
</nve-dropdown>
@@ -203,7 +203,7 @@ export const VerticalNavigationDrawer = {
203203
render: () => html`
204204
<nve-page>
205205
<nve-page-header>
206-
<nve-logo slot="prefix" size="sm"></nve-logo>
206+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
207207
<h2 slot="prefix" nve-text="heading sm">NVIDIA</h2>
208208
</nve-page-header>
209209
<main nve-layout="column gap:md pad:md">
@@ -234,7 +234,7 @@ export const VerticalNavigationPanel = {
234234
render: () => html`
235235
<nve-page>
236236
<nve-page-header>
237-
<nve-logo slot="prefix" size="sm"></nve-logo>
237+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
238238
<h2 slot="prefix" nve-text="heading sm">NVIDIA</h2>
239239
</nve-page-header>
240240
<nve-page-panel slot="left" expanded style="max-width:280px">

‎projects/core/src/page-header/page-header.snippets.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template name="Page Header" prefix="page-header" description="Basic page-header layout." type="pattern">
22
<nve-page-header slot="header">
3-
<nve-logo slot="prefix" size="sm"></nve-logo>
3+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
44
<h2 slot="prefix">${1:NVIDIA}</h2>
55
</nve-page-header>
66
</template>
@@ -11,7 +11,7 @@ <h2 slot="prefix">${1:NVIDIA}</h2>
1111
description="Basic page-header layout with links."
1212
type="pattern">
1313
<nve-page-header slot="header">
14-
<nve-logo slot="prefix" size="sm"></nve-logo>
14+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
1515
<h2 slot="prefix">${1:NVIDIA}</h2>
1616
<nve-button selected container="flat"><a href="#">${2:Link 1}</a></nve-button>
1717
<nve-button container="flat"><a href="#">${3:Link 2}</a></nve-button>

‎projects/core/src/page/page.test.visual.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function template(theme: '' | 'dark' = '') {
3636
</style>
3737
<nve-page>
3838
<nve-page-header slot="header">
39-
<nve-logo slot="prefix" size="sm"></nve-logo>
39+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
4040
<h2 nve-text="heading" slot="prefix">•︎•︎•︎•︎•︎•︎</h2>
4141
</nve-page-header>
4242

‎projects/core/src/preferences-input/preferences-input.examples.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export const Dropdown = {
6666
render: () => {
6767
return html`
6868
<nve-page-header>
69-
<nve-logo slot="prefix" size="sm"></nve-logo>
69+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
7070
<h2 slot="prefix" nve-text="heading sm">NVIDIA</h2>
7171
<nve-icon-button slot="suffix" icon-name="gear" size="sm" popovertarget="preferences-input"></nve-icon-button>
7272
</nve-page-header>

‎projects/site/src/_internal/animated-build/animated-build.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ export class AnimatedBuild extends LitElement {
228228
<div id="page-wrapper" class="layer">
229229
<nve-page class="layer">
230230
<nve-page-header slot="header" class="layer" style="--delay: 0.7s">
231-
<nve-logo slot="prefix" size="sm"></nve-logo>
231+
<nve-logo slot="prefix" size="sm">NV</nve-logo>
232232
<h2 nve-text="heading" slot="prefix">Scenario Management</h2>
233233
<nve-button container="flat">Scenario Catalog</nve-button>
234234
<nve-button selected container="flat">Browse Clips</nve-button>

0 commit comments

Comments
 (0)