[O] 同头星星不用同头写法的情况的兼容

Author: Starrah

chart/Slide.cs

@@ -75,7 +75,7 @@ public override Duration Duration
         }
     }
 
-    private string DebuggerDisplay()
+    internal string DebuggerDisplay()
     {
         string result;
         if (SharedHeadWith != null) result = "*";

generator/MA2Generator.cs

@@ -71,6 +71,8 @@ protected int T(Rational r, int offset = 0)
         if (offset != 0) result = Math.Max(result + offset, result > 0 ? 1 : 0);
         return result;
     }
+    protected int T(int bar, int tick) => bar * RSL + tick;
+    protected int T(MA2Line ma2Line) => T(ma2Line.Bar, ma2Line.Tick);
 
     protected void Warn(string description, Note note, MA2Line? ma2Line = null)
     {
@@ -94,13 +96,33 @@ protected void Warn(string description, Note note, MA2Line? ma2Line = null)
         return new MA2Line(prefix + name, bar, tick, tap.Key - 1, extra);
     }
 
+    private HashSet<string> _broadTap = ["TAP", "HLD", "STR", "BRK", "XTP", "XHO", "BST", "XST"];
+    protected bool hasSameTimeTap(MA2Line ma2Line)
+    {
+        var curT = T(ma2Line);
+        for (int i = lines.Count - 1; i >=0 ; i--)
+        {
+            var l = lines[i];
+            var lT = l.Bar * RSL + l.Tick;
+            if (T(l) < curT) break;
+            if (T(l) == curT && l.Key == ma2Line.Key && // 同一时间、同一键位、都是广义tap
+                _broadTap.Contains(l.Name[^3..]) && _broadTap.Contains(ma2Line.Name[^3..])) return true;
+        }
+        return false;
+    }
+
     protected virtual List<MA2Line> AddSlide(Slide slide, int bar, int tick)
     {
         List<MA2Line> result = [];
         if (slide.OwnHead != null)
         {
             var headTap = AddTap(slide.OwnHead, bar, tick);
-            if (headTap != null) result.Add(headTap);
+            if (headTap != null)
+            {
+                if (hasSameTimeTap(headTap))
+                    alerts.Add(new Alert(Warning, Locale.SimultaneousSlideHead, (chart, slide.OwnHead.Time), null, slide.DebuggerDisplay()));
+                else result.Add(headTap);
+            }
         }
 
         // 首先很重要的一点是，详见 https://github.com/Neskol/MaiLib/issues/46#issuecomment-3301893924 ，

generator/MA2_103Generator.cs

@@ -1,4 +1,6 @@
 using MuConvert.chart;
+using MuConvert.utils;
+using static MuConvert.utils.Alert.LEVEL;
 
 namespace MuConvert.generator;
 
@@ -41,7 +43,12 @@ protected override List<MA2Line> AddSlide(Slide slide, int bar, int tick)
         if (slide.OwnHead != null)
         {
             var headTap = AddTap(slide.OwnHead, bar, tick);
-            if (headTap != null) result.Add(headTap);
+            if (headTap != null)
+            {
+                if (hasSameTimeTap(headTap))
+                    alerts.Add(new Alert(Warning, Locale.SimultaneousSlideHead, (chart, slide.OwnHead.Time), null, slide.DebuggerDisplay()));
+                else result.Add(headTap);
+            }
         }
 
         var seg = slide.segments[0];

i18n/Locale.Designer.cs

@@ -211,4 +211,7 @@
   <data name="FixModifiersOnHead" xml:space="preserve">
     <value>For Slide's head, modifiers should appear after the key number and before the slide type notation.</value>
   </data>
+  <data name="SimultaneousSlideHead" xml:space="preserve">
+    <value>Detected another Slide head/Tap at the same time and position as this Slide head. This would cause judgement issues in-game. Fixed automatically (removed the redundant Slide head(s)). PS: If you intend same-head Slides, use syntax like "1-2*-3" rather than "1-2/1-3"; the latter triggers this issue.</value>
+  </data>
 </root>

i18n/Locale.resx

@@ -211,4 +211,7 @@
   <data name="FixModifiersOnHead" xml:space="preserve">
     <value>对星星头的修饰符，应该出现在键位号后、星星类型标记之前</value>
   </data>
+  <data name="SimultaneousSlideHead" xml:space="preserve">
+    <value>检测到在星星头所在的时刻和位置，存在着其他星星头/Tap，这会造成游戏内的绝对无理。已自动为您修复（去除多余的星星头）。PS：如果您要编写同头星星，请使用类似"1-2*-3"而非"1-2/1-3"的写法，后者就会造成上面的情况。</value>
+  </data>
 </root>

i18n/Locale.zh-hans.resx

@@ -211,4 +211,7 @@
   <data name="FixModifiersOnHead" xml:space="preserve">
     <value>對星星頭的修飾符，應該出現在鍵位號後、星星類型標記之前</value>
   </data>
+  <data name="SimultaneousSlideHead" xml:space="preserve">
+    <value>檢測到在星星頭所在的時刻與位置，存在其他星星頭/Tap，這會造成遊戲內的絕對無理。已自動為您修復（移除多餘的星星頭）。PS：若您要編寫同頭星星，請使用類似「1-2*-3」而非「1-2/1-3」的寫法；後者會造成上述情況。</value>
+  </data>
 </root>

i18n/Locale.zh-hant.resx

@@ -27,7 +27,10 @@ public static IEnumerable<object[]> OfficialLevel5()
 
         foreach (var maidataPath in Directory.EnumerateFiles(testsetRoot, "maidata.txt", SearchOption.AllDirectories)
                      .OrderBy(p => p, StringComparer.Ordinal))
+        {
+            if (!File.Exists(Path.Combine(Path.GetDirectoryName(maidataPath)!, "03.ma2"))) continue;
             yield return [new TestInput(maidataPath, levelId)];
+        }
     }
 
     private static List<string> T_JUDGE_HLD不准确所以不测 = ["系ぎて", "PANDORA PARADOXXX", "Xaleid◆scopiX", "Ref：rain (for 7th Heaven)", "Grievous Lady"];