Skip to content

[PATCH] fix use of obsolete autoconf macros #133

New issue
New issue
Closed
Bug
Closed
[PATCH] fix use of obsolete autoconf macros#133
Bug
Assignees
slavaz
Labels
area: coreIssues not related to a specific subsystemprio: lowMinor problem or easily worked aroundver: 4.6.1Reproducible in version 4.6.1
Milestone
4.6.2

Description

@mc-butler
mc-butler
opened on Jan 3, 2009

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/133
Reporter metux (@metux)
Keywords vote-winnie, vote-metux, commited-master, commited-mc-4.6

This patch fixes the use of obsolete autoconf macros: AC_AIX, AC_MINIX

Applied to mc-4.6: [40d105b]
Applied to master: [c63fc34]

Note

Original attachments:

Activity

  1. mc-butler commented on Jan 3, 2009

    @mc-butler
    mc-butler
    on Jan 3, 2009
    Author

    Changed by metux (@metux) on Jan 3, 2009 at 18:23 UTC

  2. mc-butler commented on Jan 3, 2009

    @mc-butler
    mc-butler
    on Jan 3, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 3, 2009 at 21:36 UTC (comment 1)

    This patch for 4.6.1

    For 'master' branch patch is a different.

  3. mc-butler commented on Jan 3, 2009

    @mc-butler
    mc-butler
    on Jan 3, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 3, 2009 at 21:37 UTC

    patch for 'master' branch

  4. mc-butler commented on Jan 6, 2009

    @mc-butler
    mc-butler
    on Jan 6, 2009
    Author

    Changed by metux (@metux) on Jan 6, 2009 at 18:55 UTC (comment 2)

    • Keywords set to review

  5. mc-butler commented on Jan 9, 2009

    @mc-butler
    mc-butler
    on Jan 9, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 9, 2009 at 0:28 UTC (comment 3)

    Relative to: autoconf-patches at gnu.org we must don't use AC_GNU_SOURCE, AC_AIX, AC_MINIX.

    created branch '133_obsolete_autoconf_macros' from branch 'mc-4.6'

  6. mc-butler commented on Jan 9, 2009

    @mc-butler
    mc-butler
    on Jan 9, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 9, 2009 at 0:30 UTC (comment 4)

    • Owner set to slavazanko
    • Status changed from new to accepted

  7. mc-butler commented on Jan 9, 2009

    @mc-butler
    mc-butler
    on Jan 9, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 9, 2009 at 0:39 UTC (comment 5)

    In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next definitions:

    ...
AU_DEFUN([AC_GNU_SOURCE], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_AIX], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_MINIX], [AC_USE_SYSTEM_EXTENSIONS])
...

    As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS

  8. mc-butler commented on Jan 9, 2009

    @mc-butler
    mc-butler
    on Jan 9, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 9, 2009 at 15:57 UTC (comment 6)

    • Keywords changed from review to review, vote-slavazanko

  9. mc-butler commented on Jan 10, 2009

    @mc-butler
    mc-butler
    on Jan 10, 2009
    Author

    Changed by metux (@metux) on Jan 10, 2009 at 16:33 UTC (comment 7)

    • Owner changed from slavazanko to metux

  10. mc-butler commented on Jan 11, 2009

    @mc-butler
    mc-butler
    on Jan 11, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 11, 2009 at 12:23 UTC (comment 8)

    • Keywords changed from review, vote-slavazanko to review, vote-slavazanko, vote-winnie, approved

    Hey,
    Please go on and merge this fix into mc-4.6 and then merge mc-4.6 into master.

    Btw. keywords are _space_ separated.. then you'll see only a "added keywords: xyz" instead of a "added: abc, xyz removed: abc"...

    Greetings
    Winnie

  11. mc-butler commented on Jan 11, 2009

    @mc-butler
    mc-butler
    on Jan 11, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 11, 2009 at 12:24 UTC (comment 9)

    • Keywords changed from review, vote-slavazanko, vote-winnie, approved to vote-slavazanko, vote-winnie, approved

    Remove review keyword.. no more review is needed.

  12. mc-butler commented on Jan 11, 2009

    @mc-butler
    mc-butler
    on Jan 11, 2009
    Author

    Changed by metux (@metux) on Jan 11, 2009 at 18:29 UTC (comment 10)

    • Keywords changed from vote-slavazanko, vote-winnie, approved to vote-slavazanko, vote-winnie, committed-mc4.6, committed-master
    • Description edited

  13. mc-butler commented on Jan 11, 2009

    @mc-butler
    mc-butler
    on Jan 11, 2009
    Author

    Changed by metux (@metux) on Jan 11, 2009 at 18:30 UTC (comment 11)

    • Keywords changed from vote-slavazanko, vote-winnie, committed-mc4.6, committed-master to vote-slavazanko, vote-winnie, committed-mc-4.6, committed-master

  14. mc-butler commented on Jan 13, 2009

    @mc-butler
    mc-butler
    on Jan 13, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 13, 2009 at 8:19 UTC (comment 12)

    @metux: Can you set please resolution to fixed if it is really commited to mc-4.6 and master? As I'm online currently from a win pc (from a friend) I can't check this.

  15. mc-butler commented on Jan 13, 2009

    @mc-butler
    mc-butler
    on Jan 13, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:55 UTC (comment 13)

    • Resolution set to fixed
    • Status changed from accepted to testing

  16. mc-butler commented on Jan 13, 2009

    @mc-butler
    mc-butler
    on Jan 13, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 13, 2009 at 21:55 UTC (comment 14)

    • Status changed from testing to closed

  17. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by andrew_b (@aborodin) on Jan 29, 2009 at 8:27 UTC (comment 15)

    • Status changed from closed to reopened
    • Resolution fixed deleted

    AC_USE_SYSTEM_EXTENSIONS macro requires autoconf >= 2.60 (http://www.gnu.org/software/hello/manual/autoconf/Posix-Variants.html).
    So AC_PRERQ(2.54) in configure.ac need to be fixed.

  18. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 29, 2009 at 9:09 UTC (comment 16)

    • Owner changed from metux to slavazanko
    • Keywords changed from vote-slavazanko, vote-winnie, committed-mc-4.6, committed-master to review
    • Status changed from reopened to accepted

    Created branch 133_ac_prereq with fix; parent branch: mc-4.6

    Review, rework if need, vote please.

  19. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 29, 2009 at 9:17 UTC (comment 17)

    • Keywords changed from review to review, vote-winnie

    looks fine.

  20. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by metux (@metux) on Jan 29, 2009 at 12:43 UTC (comment 18)

    • Keywords changed from review, vote-winnie to vote-winnie, vote-metux, approved

  21. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by slavazanko (@slavaz) on Jan 29, 2009 at 12:48 UTC (comment 19)

    • Keywords changed from vote-winnie, vote-metux, approved to vote-winnie, vote-metux, commited-master, commited-mc-4.6
    • Status changed from accepted to testing
    • Resolution set to fixed

    Merge to master: [d5565fb]

    Merge to mc-4.6: [6a26036]

  22. mc-butler commented on Jan 29, 2009

    @mc-butler
    mc-butler
    on Jan 29, 2009
    Author

    Changed by winnie (@winnieXY) on Jan 29, 2009 at 21:12 UTC (comment 20)

    • Status changed from testing to closed
  23. mc-butler
    closed this as completedon Jan 29, 2009
  24. mc-butler
    assigned
    slavaz
    on Feb 27, 2025
  25. mc-butler
    added the
    Bug
    issue type on Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: coreIssues not related to a specific subsystemprio: lowMinor problem or easily worked aroundver: 4.6.1Reproducible in version 4.6.1

Type

Bug

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions