Skip to content

Commit e12577c

Browse files
sbryngelsonclaude
andcommitted
Fix moncon_cutoff declared as integer, truncating 1e-8 to 0
moncon_cutoff is assigned 1e-8_wp but declared as integer, so Fortran silently truncates it to 0. This makes all THINC monotonicity constraint comparisons always true, completely disabling the constraint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 84c46e0 commit e12577c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/common/m_constants.fpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module m_constants
4444
! Interface Compression
4545
real(wp), parameter :: dflt_ic_eps = 1e-4_wp !< Ensure compression is only applied to surface cells in THINC
4646
real(wp), parameter :: dflt_ic_beta = 1.6_wp !< Sharpness parameter's default value used in THINC
47-
integer, parameter :: moncon_cutoff = 1e-8_wp !< Monotonicity constraint's limiter to prevent extremas in THINC
47+
real(wp), parameter :: moncon_cutoff = 1e-8_wp !< Monotonicity constraint's limiter to prevent extremas in THINC
4848

4949
! Chemistry
5050
real(wp), parameter :: dflt_T_guess = 1200._wp ! Default guess for temperature (when a previous value is not available)

0 commit comments

Comments
 (0)