Remove CCE VLA guard from m_chemistry.fpp; slim CI to Frontier (CCE) only

1,500+ stress-test rounds on CCE 19.0.0 showed zero ICEs with plain
dimension(num_species) local arrays in m_chemistry.fpp. Remove all
#:if USING_CCE fixed-size array guards, the CCE_MAX_SPECIES Fypp
constant, the @:PROHIBIT runtime checks, and the matching Python-side
species-count validation in input.py.

Simplify the compound AMD guard from
  (not MFC_CASE_OPTIMIZATION and USING_AMD) or USING_CCE
to
  not MFC_CASE_OPTIMIZATION and USING_AMD
with a literal dimension(10) — the AMD workaround is preserved.

The -Oipa0 per-file CMake flags for m_bubbles_EL and m_phase_change
are kept; those ICEs are confirmed required by 20/20 positive-control
rounds and GitHub CI history.

Temporarily remove non-CCE jobs from CI (GitHub runners, Phoenix,
Frontier-AMD) to focus test bandwidth on the CCE fix branch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Spencer Bryngelson

.github/workflows/bench.yml

@@ -37,22 +37,7 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - cluster: phoenix
-            name: Georgia Tech | Phoenix (NVHPC)
-            group: phoenix
-            labels: gt
-            flag: p
-            device: gpu
-            interface: acc
-            build_script: ""
-          - cluster: phoenix
-            name: Georgia Tech | Phoenix (NVHPC)
-            group: phoenix
-            labels: gt
-            flag: p
-            device: gpu
-            interface: omp
-            build_script: ""
+          # Frontier (ORNL) — CCE only
           - cluster: frontier
             name: Oak Ridge | Frontier (CCE)
             group: phoenix
@@ -69,14 +54,6 @@ jobs:
             device: gpu
             interface: omp
             build_script: "bash .github/workflows/frontier/build.sh gpu omp bench"
-          - cluster: frontier_amd
-            name: Oak Ridge | Frontier (AMD)
-            group: phoenix
-            labels: frontier
-            flag: famd
-            device: gpu
-            interface: omp
-            build_script: "bash .github/workflows/frontier_amd/build.sh gpu omp bench"
     runs-on:
       group: ${{ matrix.group }}
       labels: ${{ matrix.labels }}

.github/workflows/test.yml

@@ -68,99 +68,6 @@ jobs:
         with: 
           filters: ".github/file-filter.yml"
 
-  github:
-    name: Github
-    if: needs.file-changes.outputs.checkall == 'true'
-    needs: [lint-gate, file-changes]
-    strategy:
-      matrix:
-        os:    ['ubuntu', 'macos']
-        mpi:   ['mpi']
-        precision: ['']
-        debug: ['debug', 'no-debug']
-        intel: [true, false]
-        exclude:
-          - os:    macos
-            intel: true
-
-        include:
-          - os:    ubuntu
-            mpi:   no-mpi
-            precision: single
-            debug: no-debug
-            intel: false
-
-      fail-fast: false
-    continue-on-error: true
-    runs-on: ${{ matrix.os }}-latest
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v4
-
-      - name: Setup MacOS
-        if:   matrix.os == 'macos'
-        run:  |
-          brew update
-          brew upgrade
-          brew install coreutils python fftw hdf5 gcc@15 boost open-mpi lapack
-          echo "FC=gfortran-15" >> $GITHUB_ENV
-          echo "BOOST_INCLUDE=/opt/homebrew/include/" >> $GITHUB_ENV
-
-      - name: Setup Ubuntu
-        if:   matrix.os == 'ubuntu' && matrix.intel == false
-        run: |
-           sudo apt update -y
-           sudo apt install -y cmake gcc g++ python3 python3-dev hdf5-tools \
-                    libfftw3-dev libhdf5-dev openmpi-bin libopenmpi-dev \
-                    libblas-dev liblapack-dev
-
-      - name: Setup Ubuntu (Intel)
-        if:   matrix.os == 'ubuntu' && matrix.intel == true
-        run: |
-          wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB
-          sudo apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB
-          sudo add-apt-repository "deb https://apt.repos.intel.com/oneapi all main"
-          sudo apt-get update
-          sudo apt-get install -y intel-oneapi-compiler-fortran intel-oneapi-mpi intel-oneapi-mpi-devel
-          # Export only new/changed env vars from setvars.sh.
-          # `printenv >> $GITHUB_ENV` dumps all vars including shell internals
-          # with special characters that corrupt GITHUB_ENV parsing.
-          printenv | sort > /tmp/env_before
-          source /opt/intel/oneapi/setvars.sh
-          printenv | sort > /tmp/env_after
-          diff /tmp/env_before /tmp/env_after | grep '^>' | sed 's/^> //' >> $GITHUB_ENV
-
-      - name: Get system info for cache key
-        id: sys-info
-        run: |
-          {
-            uname -m
-            cat /proc/cpuinfo 2>/dev/null | grep 'model name' | head -1 || sysctl -n machdep.cpu.brand_string 2>/dev/null || true
-            if command -v ifx &>/dev/null; then ifx --version 2>/dev/null | head -1; else ${FC:-gfortran} --version 2>/dev/null | head -1 || true; fi
-            ${CC:-gcc} --version 2>/dev/null | head -1 || true
-          } | (sha256sum 2>/dev/null || shasum -a 256) | cut -c1-16 > /tmp/sys-hash
-          echo "sys-hash=$(cat /tmp/sys-hash)" >> "$GITHUB_OUTPUT"
-
-      - name: Restore Build Cache
-        uses: actions/cache@v4
-        with:
-          path: build
-          key: mfc-build-${{ matrix.os }}-${{ matrix.mpi }}-${{ matrix.debug }}-${{ matrix.precision }}-${{ matrix.intel }}-${{ steps.sys-info.outputs.sys-hash }}-${{ hashFiles('CMakeLists.txt', 'toolchain/dependencies/**', 'toolchain/cmake/**', 'src/**/*.fpp', 'src/**/*.f90') }}
-
-      - name: Build
-        run:  |
-          /bin/bash mfc.sh test -v --dry-run -j "$(nproc)" --${{ matrix.debug }} --${{ matrix.mpi }} $PRECISION $TEST_ALL
-        env:
-          TEST_ALL: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}
-          PRECISION: ${{ matrix.precision != '' && format('--{0}', matrix.precision) || '' }}
-
-      - name: Test
-        run: bash .github/scripts/run-tests-with-retry.sh -v --max-attempts 3 -j "$(nproc)" $TEST_ALL $TEST_PCT
-        env:
-          TEST_ALL: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}
-          TEST_PCT: ${{ matrix.debug == 'debug' && '-% 20' || '' }}
-
   self:
     name: "${{ matrix.cluster_name }} (${{ matrix.device }}${{ matrix.interface != 'none' && format('-{0}', matrix.interface) || '' }}${{ matrix.shard != '' && format(' [{0}]', matrix.shard) || '' }})"
     if: github.repository == 'MFlowCode/MFC' && needs.file-changes.outputs.checkall == 'true' && github.event.pull_request.draft != true
@@ -170,23 +77,7 @@ jobs:
     strategy:
       matrix:
         include:
-          # Phoenix (GT) — build+test combined in SLURM job
-          - runner:       'gt'
-            cluster:      'phoenix'
-            cluster_name: 'Georgia Tech | Phoenix'
-            device: 'gpu'
-            interface: 'acc'
-          - runner:       'gt'
-            cluster:      'phoenix'
-            cluster_name: 'Georgia Tech | Phoenix'
-            device: 'gpu'
-            interface: 'omp'
-          - runner:       'gt'
-            cluster:      'phoenix'
-            cluster_name: 'Georgia Tech | Phoenix'
-            device: 'cpu'
-            interface: 'none'
-          # Frontier (ORNL) — build on login node, GPU tests sharded for batch partition
+          # Frontier (ORNL) — CCE only
           - runner:       'frontier'
             cluster:      'frontier'
             cluster_name: 'Oak Ridge | Frontier'
@@ -216,24 +107,6 @@ jobs:
             cluster_name: 'Oak Ridge | Frontier'
             device: 'cpu'
             interface: 'none'
-          # Frontier AMD — build on login node, GPU tests sharded for batch partition
-          - runner:       'frontier'
-            cluster:      'frontier_amd'
-            cluster_name: 'Oak Ridge | Frontier (AMD)'
-            device: 'gpu'
-            interface: 'omp'
-            shard: '1/2'
-          - runner:       'frontier'
-            cluster:      'frontier_amd'
-            cluster_name: 'Oak Ridge | Frontier (AMD)'
-            device: 'gpu'
-            interface: 'omp'
-            shard: '2/2'
-          - runner:       'frontier'
-            cluster:      'frontier_amd'
-            cluster_name: 'Oak Ridge | Frontier (AMD)'
-            device: 'cpu'
-            interface: 'none'
     runs-on:
       group:  phoenix
       labels: ${{ matrix.runner }}
@@ -289,16 +162,7 @@ jobs:
     strategy:
       matrix:
         include:
-          - runner:       'gt'
-            cluster:      'phoenix'
-            cluster_name: 'Georgia Tech | Phoenix'
-            device: 'gpu'
-            interface: 'acc'
-          - runner:       'gt'
-            cluster:      'phoenix'
-            cluster_name: 'Georgia Tech | Phoenix'
-            device: 'gpu'
-            interface: 'omp'
+          # Frontier (ORNL) — CCE only
           - runner:       'frontier'
             cluster:      'frontier'
             cluster_name: 'Oak Ridge | Frontier'
@@ -309,11 +173,6 @@ jobs:
             cluster_name: 'Oak Ridge | Frontier'
             device: 'gpu'
             interface: 'omp'
-          - runner:       'frontier'
-            cluster:      'frontier_amd'
-            cluster_name: 'Oak Ridge | Frontier (AMD)'
-            device: 'gpu'
-            interface: 'omp'
     runs-on:
       group:  phoenix
       labels: ${{ matrix.runner }}

.gitignore

@@ -105,4 +105,8 @@ benchmarks/*.png
 *.avi
 
 **isolation_rules/
-**.supercode/
+**.supercode/
+# CCE stress-test log directories (local testing artifacts)
+cce_*/
+cce_*.log
+run_cce_*.sh

src/common/m_chemistry.fpp

@@ -6,10 +6,6 @@
 #:include 'macros.fpp'
 #:include 'case.fpp'
 
-#! CCE 19.0.0 workaround: fixed-size array limit for local species arrays under _CRAYFTN.
-#! Must match the Python-side check in toolchain/mfc/run/input.py. See PR #1286.
-#:set CCE_MAX_SPECIES = 10
-
 !> @brief Multi-species chemistry interface for thermodynamic properties, reaction rates, and transport coefficients
 module m_chemistry
 
@@ -67,15 +63,7 @@ contains
 
         integer :: x, y, z, eqn
         real(wp) :: energy, T_in
-        #:if USING_CCE
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: Ys
-        #:else
-            real(wp), dimension(num_species) :: Ys
-        #:endif
-
-        #:if USING_CCE
-            @:PROHIBIT(num_species > ${CCE_MAX_SPECIES}$, "CCE 19.0.0 workaround: num_species must be <= ${CCE_MAX_SPECIES}$ (fixed-size arrays in m_chemistry.fpp)")
-        #:endif
+        real(wp), dimension(num_species) :: Ys
 
         do z = bounds(3)%beg, bounds(3)%end
             do y = bounds(2)%beg, bounds(2)%end
@@ -113,17 +101,9 @@ contains
         type(int_bounds_info), dimension(1:3), intent(in) :: bounds
 
         integer :: x, y, z, i
-        #:if USING_CCE
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: Ys
-        #:else
-            real(wp), dimension(num_species) :: Ys
-        #:endif
+        real(wp), dimension(num_species) :: Ys
         real(wp) :: mix_mol_weight
 
-        #:if USING_CCE
-            @:PROHIBIT(num_species > ${CCE_MAX_SPECIES}$, "CCE 19.0.0 workaround: num_species must be <= ${CCE_MAX_SPECIES}$ (fixed-size arrays in m_chemistry.fpp)")
-        #:endif
-
         do z = bounds(3)%beg, bounds(3)%end
             do y = bounds(2)%beg, bounds(2)%end
                 do x = bounds(1)%beg, bounds(1)%end
@@ -151,18 +131,14 @@ contains
         integer :: eqn
         real(wp) :: T
         real(wp) :: rho, omega_m
-        #:if (not MFC_CASE_OPTIMIZATION and USING_AMD) or USING_CCE
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: Ys
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: omega
+        #:if not MFC_CASE_OPTIMIZATION and USING_AMD
+            real(wp), dimension(10) :: Ys
+            real(wp), dimension(10) :: omega
         #:else
             real(wp), dimension(num_species) :: Ys
             real(wp), dimension(num_species) :: omega
         #:endif
 
-        #:if USING_CCE
-            @:PROHIBIT(num_species > ${CCE_MAX_SPECIES}$, "CCE 19.0.0 workaround: num_species must be <= ${CCE_MAX_SPECIES}$ (fixed-size arrays in m_chemistry.fpp)")
-        #:endif
-
         $:GPU_PARALLEL_LOOP(collapse=3, private='[Ys, omega, eqn, T, rho, omega_m]', copyin='[bounds]')
         do z = bounds(3)%beg, bounds(3)%end
             do y = bounds(2)%beg, bounds(2)%end
@@ -204,11 +180,11 @@ contains
         type(int_bounds_info), intent(in) :: irx, iry, irz
 
         integer, intent(in) :: idir
-        #:if (not MFC_CASE_OPTIMIZATION and USING_AMD) or USING_CCE
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: Xs_L, Xs_R, Xs_cell, Ys_L, Ys_R, Ys_cell
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: mass_diffusivities_mixavg1, mass_diffusivities_mixavg2
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: mass_diffusivities_mixavg_Cell, dXk_dxi, h_l, h_r, h_k
-            real(wp), dimension(${CCE_MAX_SPECIES}$) :: Mass_Diffu_Flux, dYk_dxi
+        #:if not MFC_CASE_OPTIMIZATION and USING_AMD
+            real(wp), dimension(10) :: Xs_L, Xs_R, Xs_cell, Ys_L, Ys_R, Ys_cell
+            real(wp), dimension(10) :: mass_diffusivities_mixavg1, mass_diffusivities_mixavg2
+            real(wp), dimension(10) :: mass_diffusivities_mixavg_Cell, dXk_dxi, h_l, h_r, h_k
+            real(wp), dimension(10) :: Mass_Diffu_Flux, dYk_dxi
         #:else
             real(wp), dimension(num_species) :: Xs_L, Xs_R, Xs_cell, Ys_L, Ys_R, Ys_cell
             real(wp), dimension(num_species) :: mass_diffusivities_mixavg1, mass_diffusivities_mixavg2
@@ -226,10 +202,6 @@ contains
         integer :: x, y, z, i, n, eqn
         integer, dimension(3) :: offsets
 
-        #:if USING_CCE
-            @:PROHIBIT(num_species > ${CCE_MAX_SPECIES}$, "CCE 19.0.0 workaround: num_species must be <= ${CCE_MAX_SPECIES}$ (fixed-size arrays in m_chemistry.fpp)")
-        #:endif
-
         isc1 = irx; isc2 = iry; isc3 = irz
 
         $:GPU_UPDATE(device='[isc1,isc2,isc3]')

toolchain/mfc/run/input.py

@@ -92,20 +92,6 @@ def generate_fpp(self, target) -> None:
         # Write the generated Fortran code to the m_thermochem.f90 file with the chosen precision
         sol = self.get_cantera_solution()
 
-        # CCE 19.0.0 workaround: m_chemistry.fpp uses dimension(CCE_MAX_SPECIES) for local
-        # species arrays on Cray builds to avoid an InstCombine ICE. Must match the Fypp
-        # constant CCE_MAX_SPECIES in src/common/m_chemistry.fpp.
-        CCE_MAX_SPECIES = 10
-        if sol.n_species > CCE_MAX_SPECIES:
-            msg = (f"Cantera mechanism has {sol.n_species} species > {CCE_MAX_SPECIES}. "
-                   f"Cray Fortran (CCE) builds use a hardcoded dimension({CCE_MAX_SPECIES}) "
-                   "workaround in m_chemistry.fpp and will abort at runtime on CCE. See PR #1286.")
-            if directive_str is not None:
-                # GPU builds: hard error — the Fortran PROHIBIT will abort anyway,
-                # so fail early at input generation rather than at the first chemistry call.
-                raise common.MFCException(msg)
-            cons.print(f"[bold yellow]Warning:[/bold yellow] {msg}")
-
         thermochem_code = pyro.FortranCodeGenerator().generate(
             "m_thermochem",
             sol,