Skip to content

Commit 7c5baa9

Browse files
committed
Clean up edits recommended by Claude
1 parent 2aa4d55 commit 7c5baa9

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/simulation/m_ibm.fpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ contains
997997

998998
integer :: gp_id, i, j, k, l, q, ib_idx, fluid_idx
999999
real(wp), dimension(num_ibs, 3) :: forces, torques
1000-
real(wp), dimension(1:3, 1:3) :: viscous_stress_div, viscous_stress_div_1, viscous_stress_div_2, viscous_cross_1, viscous_cross_2 ! viscous stress tensor with temp vectors to hold divergence calculations
1000+
real(wp), dimension(1:3, 1:3) :: viscous_stress_div, viscous_stress_div_1, viscous_stress_div_2 ! viscous stress tensor with temp vectors to hold divergence calculations
10011001
real(wp), dimension(1:3) :: local_force_contribution, radial_vector, local_torque_contribution, vel
10021002
real(wp) :: cell_volume, dx, dy, dz, dynamic_viscosity
10031003
#:if not MFC_CASE_OPTIMIZATION and USING_AMD
@@ -1021,7 +1021,7 @@ contains
10211021
end do
10221022
end if
10231023

1024-
$:GPU_PARALLEL_LOOP(private='[ib_idx,fluid_idx, radial_vector,local_force_contribution,cell_volume,local_torque_contribution, dynamic_viscosity, viscous_stress_div, viscous_stress_div_1, viscous_stress_div_2, viscous_cross_1, viscous_cross_2, dx, dy, dz]', copy='[forces,torques]', copyin='[ib_markers,patch_ib,dynamic_viscosities]', collapse=3)
1024+
$:GPU_PARALLEL_LOOP(private='[ib_idx,fluid_idx, radial_vector,local_force_contribution,cell_volume,local_torque_contribution, dynamic_viscosity, viscous_stress_div, viscous_stress_div_1, viscous_stress_div_2, dx, dy, dz]', copy='[forces,torques]', copyin='[ib_markers,patch_ib,dynamic_viscosities]', collapse=3)
10251025
do i = 0, m
10261026
do j = 0, n
10271027
do k = 0, p
@@ -1051,7 +1051,6 @@ contains
10511051
end do
10521052

10531053
! get the viscous stress and add its contribution if that is considered
1054-
! TODO :: This is really bad code
10551054
if (viscous) then
10561055
! compute the volume-weighted local dynamic viscosity
10571056
dynamic_viscosity = 0._wp
@@ -1074,15 +1073,15 @@ contains
10741073
if (num_dims == 3) then
10751074
call s_compute_viscous_stress_tensor(viscous_stress_div_1, q_prim_vf, dynamic_viscosity, i, j, k - 1)
10761075
call s_compute_viscous_stress_tensor(viscous_stress_div_2, q_prim_vf, dynamic_viscosity, i, j, k + 1)
1077-
viscous_stress_div(3, 1:3) = (viscous_stress_div_2(3, 1:3) - viscous_stress_div_1(3, 1:3))/(2._wp*dz) ! get z derivative of the second-row of viscous stress tensor
1076+
viscous_stress_div(3, 1:3) = (viscous_stress_div_2(3, 1:3) - viscous_stress_div_1(3, 1:3))/(2._wp*dz) ! get z derivative of the third-row of viscous stress tensor
10781077
local_force_contribution(1:3) = local_force_contribution(1:3) + viscous_stress_div(3, 1:3) ! add the z components of the divergence to the force
10791078
end if
10801079

10811080
end if
10821081

10831082
call s_cross_product(radial_vector, local_force_contribution, local_torque_contribution)
10841083

1085-
! Update the force values atomically to prevent race conditions
1084+
! Update the force and torque values atomically to prevent race conditions
10861085
do l = 1, 3
10871086
$:GPU_ATOMIC(atomic='update')
10881087
forces(ib_idx, l) = forces(ib_idx, l) + (local_force_contribution(l)*cell_volume)

0 commit comments

Comments
 (0)