Skip to content

Commit afcc5e5

Browse files
committed
Revert "Merge pull request #26 from letter333/WEEK9"
This reverts commit a1d4647, reversing changes made to db2ae32.
1 parent 872e594 commit afcc5e5

39 files changed

+14
-1551
lines changed

apps/commerce-api/src/main/java/com/loopers/application/event/ProductViewedEvent.java

Lines changed: 0 additions & 6 deletions
This file was deleted.

apps/commerce-api/src/main/java/com/loopers/application/kafka/OutboxEventRecorder.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.loopers.application.event.OrderCompletedEvent;
66
import com.loopers.application.event.ProductLikedEvent;
77
import com.loopers.application.event.ProductUnlikedEvent;
8-
import com.loopers.application.event.ProductViewedEvent;
98
import com.loopers.domain.outbox.OutboxEventService;
109
import lombok.RequiredArgsConstructor;
1110
import org.springframework.context.event.EventListener;
@@ -52,16 +51,6 @@ public void handleProductUnliked(ProductUnlikedEvent event) {
5251
);
5352
}
5453

55-
@EventListener
56-
public void handleProductViewed(ProductViewedEvent event) {
57-
outboxEventService.recordEvent(
58-
OutboxAggregateType.PRODUCT,
59-
String.valueOf(event.productId()),
60-
OutboxEventType.PRODUCT_VIEWED,
61-
toJson(Map.of("productId", event.productId()))
62-
);
63-
}
64-
6554
@EventListener
6655
public void handleOrderCompleted(OrderCompletedEvent event) {
6756
outboxEventService.recordEvent(

apps/commerce-api/src/main/java/com/loopers/application/kafka/OutboxEventType.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ private OutboxEventType() {}
77
public static final String PRODUCT_LIKED = "PRODUCT_LIKED";
88
public static final String PRODUCT_UNLIKED = "PRODUCT_UNLIKED";
99
public static final String ORDER_COMPLETED = "ORDER_COMPLETED";
10-
public static final String PRODUCT_VIEWED = "PRODUCT_VIEWED";
1110
}

apps/commerce-api/src/main/java/com/loopers/application/product/ProductCacheEvictListener.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.loopers.application.product;
22

3-
import com.loopers.domain.ranking.ProductRankingRepository;
43
import lombok.RequiredArgsConstructor;
54
import org.springframework.stereotype.Component;
65
import org.springframework.transaction.event.TransactionPhase;
@@ -12,14 +11,10 @@ public class ProductCacheEvictListener {
1211

1312
private final ProductDetailCacheRepository productDetailCacheRepository;
1413
private final ProductListCacheRepository productListCacheRepository;
15-
private final ProductRankingRepository productRankingRepository;
1614

1715
@TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT)
1816
public void handleCacheEvict(ProductCacheEvictEvent event) {
19-
event.productIds().forEach(productId -> {
20-
productDetailCacheRepository.evict(productId);
21-
productRankingRepository.removeProduct(productId);
22-
});
17+
event.productIds().forEach(productDetailCacheRepository::evict);
2318
if (event.evictList()) {
2419
productListCacheRepository.evictAll();
2520
}

apps/commerce-api/src/main/java/com/loopers/application/product/ProductFacade.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.loopers.domain.brand.BrandService;
66
import com.loopers.domain.category.CategoryService;
77
import com.loopers.domain.product.Product;
8-
import com.loopers.application.event.ProductViewedEvent;
98
import com.loopers.domain.product.ProductService;
109
import com.loopers.domain.product.ProductSortType;
1110
import com.loopers.support.auth.AdminValidator;
@@ -32,9 +31,8 @@ public class ProductFacade {
3231
private final ProductListCacheRepository productListCacheRepository;
3332
private final ApplicationEventPublisher applicationEventPublisher;
3433

35-
@Transactional
34+
@Transactional(readOnly = true)
3635
public ProductDetailInfo getProduct(Long productId) {
37-
applicationEventPublisher.publishEvent(new ProductViewedEvent(productId));
3836
return productDetailCacheRepository.get(productId)
3937
.orElseGet(() -> {
4038
Product product = productService.getActiveProduct(productId);

apps/commerce-api/src/main/java/com/loopers/application/ranking/RankingDetailInfo.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

apps/commerce-api/src/main/java/com/loopers/application/ranking/RankingFacade.java

Lines changed: 0 additions & 85 deletions
This file was deleted.

apps/commerce-api/src/main/java/com/loopers/application/ranking/RankingInfo.java

Lines changed: 0 additions & 28 deletions
This file was deleted.

apps/commerce-api/src/main/java/com/loopers/domain/product/ProductRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ public interface ProductRepository {
2222

2323
Page<Product> findProducts(Long categoryId, Long brandId, String keyword, ProductSortType sort, Pageable pageable);
2424

25-
List<Product> findByIds(List<Long> ids);
26-
2725
Product save(Product product);
2826

2927
void delete(Long id);

apps/commerce-api/src/main/java/com/loopers/domain/product/ProductService.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ public Product getActiveProduct(Long productId) {
3232
return product;
3333
}
3434

35-
@Transactional(readOnly = true, propagation = Propagation.SUPPORTS)
36-
public List<Product> getProductsByIds(List<Long> ids) {
37-
return productRepository.findByIds(ids);
38-
}
39-
4035
@Transactional(readOnly = true, propagation = Propagation.SUPPORTS)
4136
public List<Product> getAllActiveProducts() {
4237
return productRepository.findAllActive();

0 commit comments

Comments
 (0)