Merge write benchmarks#14
Merged
Merged
Conversation
Member
Author
|
I'm gonna go ahead and merge this, because there are bigger fish to fry (for which we actually need these benchmarks) and this project is in its infancy anyway. My use of terms like "Simple Moving Average" may be incorrect (IANAMathematician), that can be fixed later if need be. @peakji @ralphtheninja LMK if you disagree and want me to slow down to give you time to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
write,write-sorted,write-randominto a singleputbenchmark (closes Merge write, -sorted and -random benchmarks into one #6, closes Don't use monotonic-timestamp for write-sorted benchmark #9), using options like--keys seqto switch between random and sequential keys (as well as strings and buffers)crypto(less blocking)write, but unlikewrite-sortedandwrite-randomwhich did not aggregate)Buffer.byteLength()to compute total bytes written (closes Reported bytes written is incorrect (too low) #8)x.toFixed(3)instead ofMath.floor(x)Example of what this enables: compare write perf of sequential vs random keys:
Click to expand