This repository was archived by the owner on Jan 18, 2025. It is now read-only.
Fix parse the content for openGraph image for github#145
Merged
leonardocardoso merged 1 commit intoJul 27, 2021
Merged
Conversation
Contributor
|
It likely doesn't make sense to try to match this URL against a pattern to try and detect it; instead some tag values should just be assumed to be referencing image URLs without using any pattern testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Description: Invalid response image attribute in case of any GitHub URL
Issue: Github Repository Image not parsed properly #144
Commit: 4701a0e
Changelog
Basically, the meta tag containing the target image in GitHub site looks like this. It has no extension as stated below.
So, this image pattern used for this particular case cant detect it.
static let imagePattern = "(.+?)\\.(gif|jpg|jpeg|png|bmp)$"Also, first checking for "og:image" tag gets the right image as tested.