From 45646aa6f9a5390276683c8985390d5d58a73110 Mon Sep 17 00:00:00 2001 From: philluiz2323 Date: Sat, 25 Jul 2026 18:55:22 -0700 Subject: [PATCH] fix(miner): drop stale ProcessEnv casts on resolveReplaySnapshotDbPath The resolver already types env as Record; remove the outdated not-yet-migrated comments and casts at both migrate-cli and status call sites. Closes #8642 --- packages/loopover-miner/lib/migrate-cli.ts | 9 +-------- packages/loopover-miner/lib/status.ts | 3 +-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/loopover-miner/lib/migrate-cli.ts b/packages/loopover-miner/lib/migrate-cli.ts index 62a5309217..e71ce66304 100644 --- a/packages/loopover-miner/lib/migrate-cli.ts +++ b/packages/loopover-miner/lib/migrate-cli.ts @@ -60,14 +60,7 @@ const STORES: MigrateStoreDescriptor[] = [ { name: "plan-store", resolveDbPath: resolvePlanStoreDbPath, open: openPlanStore }, { name: "governor-state", resolveDbPath: resolveGovernorStateDbPath, open: openGovernorState }, { name: "attempt-log", resolveDbPath: resolveAttemptLogDbPath, open: initAttemptLog }, - { - name: "replay-snapshot", - // resolveReplaySnapshotDbPath's own (not-yet-converted) .d.ts types `env` as `NodeJS.ProcessEnv`, unlike - // every sibling resolver here (`Record`) -- a pre-existing inconsistency, not - // introduced by this batch. process.env genuinely satisfies both shapes at runtime, so this cast is safe. - resolveDbPath: resolveReplaySnapshotDbPath as (env?: Record) => string, - open: openReplaySnapshotStore, - }, + { name: "replay-snapshot", resolveDbPath: resolveReplaySnapshotDbPath, open: openReplaySnapshotStore }, { name: "worktree-allocator", resolveDbPath: resolveWorktreeAllocatorDbPath, diff --git a/packages/loopover-miner/lib/status.ts b/packages/loopover-miner/lib/status.ts index f97b64bf72..d2d9a56955 100644 --- a/packages/loopover-miner/lib/status.ts +++ b/packages/loopover-miner/lib/status.ts @@ -399,8 +399,7 @@ function storeIntegrityChecks(env: Record): DoctorCh ["plan-store", resolvePlanStoreDbPath(env)], ["governor-state", resolveGovernorStateDbPath(env)], ["attempt-log", resolveAttemptLogDbPath(env)], - // replay-snapshot's .d.ts still types env as ProcessEnv (not yet migrated); cast is lossless. - ["replay-snapshot", resolveReplaySnapshotDbPath(env as NodeJS.ProcessEnv)], + ["replay-snapshot", resolveReplaySnapshotDbPath(env)], ["worktree-allocator", resolveWorktreeAllocatorDbPath(env)], ["contribution-profile", resolveContributionProfileCacheDbPath(env)], ["policy-verdict-cache", resolvePolicyVerdictCacheDbPath(env)],