From fbfb5fcd1e3c0e078f2b4a28a242abfa110e123d Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Tue, 14 Jul 2026 14:39:27 -0700 Subject: [PATCH] fix(review): restore engine-parity after gittensory rename drift PR #5883 renamed brand-name prose in src/review/guardrail-config.ts and src/review/linked-issue-label-propagation.ts but not their byte-identical twins under packages/loopover-engine/src/review/, breaking scripts/check-engine-parity.ts on main. Aligns the engine copies' comment text with the host copies. Also fixes a stale finding-taxonomy.test.ts assertion that still expected the pre-rename "gittensory://finding-taxonomy" MCP resource URI literal (the constant itself was already correctly renamed by #5883; only this test's hardcoded expectation had drifted). --- packages/loopover-engine/src/review/guardrail-config.ts | 2 +- .../src/review/linked-issue-label-propagation.ts | 2 +- test/unit/finding-taxonomy.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/loopover-engine/src/review/guardrail-config.ts b/packages/loopover-engine/src/review/guardrail-config.ts index d4d772f249..02614de495 100644 --- a/packages/loopover-engine/src/review/guardrail-config.ts +++ b/packages/loopover-engine/src/review/guardrail-config.ts @@ -32,7 +32,7 @@ export const ENGINE_DECISION_GUARDRAIL_GLOBS = [ "src/github/pr-actions.ts", "src/github/app.ts", "src/github/backfill.ts", - // #4197: writes a real commit onto a CONTRIBUTOR's own PR branch (not a branch gittensory owns) — the same + // #4197: writes a real commit onto a CONTRIBUTOR's own PR branch (not a branch loopover owns) — the same // guardrail tier as pr-actions.ts/app.ts for the same reason, a new GitHub-write surface. "src/github/e2e-test-commit.ts", "src/scoring/**", diff --git a/packages/loopover-engine/src/review/linked-issue-label-propagation.ts b/packages/loopover-engine/src/review/linked-issue-label-propagation.ts index d9ae9561bb..75da42aa71 100644 --- a/packages/loopover-engine/src/review/linked-issue-label-propagation.ts +++ b/packages/loopover-engine/src/review/linked-issue-label-propagation.ts @@ -10,7 +10,7 @@ export type { LinkedIssueLabelPropagationConfig, LinkedIssueLabelPropagationMapp // (replaces the normal bug/feature type label, like priority does) or additive (applied alongside it). // // PURE config types + normalizer only — no GitHub/fetch/Env-dependent imports. `focus-manifest.ts`'s YAML -// parser imports this module directly, and `focus-manifest.ts` is itself pulled into the gittensory-ui +// parser imports this module directly, and `focus-manifest.ts` is itself pulled into the loopover-ui // workspace's isolated typecheck (via `apps/loopover-ui/src/lib/registration-workspace.ts`), which has no // visibility into the Worker's ambient `Env` type. The actual GitHub fetch orchestrator // (`fetchLinkedIssueLabelsForPropagation`) lives in `linked-issue-label-propagation-fetch.ts` instead, kept diff --git a/test/unit/finding-taxonomy.test.ts b/test/unit/finding-taxonomy.test.ts index e4ea8e70e5..9bfc610892 100644 --- a/test/unit/finding-taxonomy.test.ts +++ b/test/unit/finding-taxonomy.test.ts @@ -23,6 +23,6 @@ describe("finding taxonomy document", () => { }); it("uses the stable MCP resource URI", () => { - expect(FINDING_TAXONOMY_URI).toBe("gittensory://finding-taxonomy"); + expect(FINDING_TAXONOMY_URI).toBe("loopover://finding-taxonomy"); }); });