From f2ecc66560b429dd42751684e8c64fb6595f9c12 Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Fri, 10 Jul 2026 01:13:53 -0700 Subject: [PATCH] test(api): read the expected MCP version dynamically instead of hardcoding it src/services/mcp-compatibility.ts derives LATEST_RECOMMENDED_MCP_VERSION live from packages/gittensory-mcp/package.json, but these assertions hardcoded "0.7.0" -- every release-please version bump silently breaks them (confirmed: #4204's 0.7.0->0.7.1 bump fails validate-code on exactly these lines). Mirrors the mcpPackageJson.version pattern test/unit/mcp-cli-doctor.test.ts already uses, so this doesn't recur on the next release. --- test/integration/api.test.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/integration/api.test.ts b/test/integration/api.test.ts index 2bfd7bc5d1..7be1f55f45 100644 --- a/test/integration/api.test.ts +++ b/test/integration/api.test.ts @@ -1,4 +1,5 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; +import mcpPackageJson from "../../packages/gittensory-mcp/package.json"; import { createSessionForGitHubUser, hashToken } from "../../src/auth/security"; import { upsertBounty, @@ -97,7 +98,7 @@ describe("api routes", () => { status: "ok", service: "gittensory-api", minMcpVersion: "0.5.0", - latestRecommendedMcpVersion: "0.7.0", + latestRecommendedMcpVersion: mcpPackageJson.version, }); const compatibility = await app.request("/v1/mcp/compatibility", {}, env); @@ -110,8 +111,8 @@ describe("api routes", () => { mcp: { packageName: "@jsonbored/gittensory-mcp", minimumSupportedVersion: "0.5.0", - latestRecommendedVersion: "0.7.0", - latestPackageVersion: "0.7.0", + latestRecommendedVersion: mcpPackageJson.version, + latestPackageVersion: mcpPackageJson.version, }, compatibilityWarnings: [], breakingChanges: [], @@ -3964,7 +3965,7 @@ describe("api routes", () => { expect(mcpCompatibilityBody).toMatchObject({ adoption: expect.objectContaining({ minimumSupportedVersion: "0.5.0", - latestRecommendedVersion: "0.7.0", + latestRecommendedVersion: mcpPackageJson.version, staleEvents: 1, incompatibleEvents: 3, totalEvents: 4, @@ -5855,7 +5856,7 @@ describe("api routes", () => { protocolVersion: "2025-03-26", compatibilityStatus: "incompatible", minimumSupportedVersion: "0.5.0", - latestRecommendedVersion: "0.7.0", + latestRecommendedVersion: mcpPackageJson.version, }), }), ]),