fix(content-lane): add snake_case source-url aliases to sourceUrlFields (#7250) - #7269
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7269 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 704 704
Lines 69457 69457
Branches 18899 18899
=======================================
Hits 65161 65161
Misses 3302 3302
Partials 994 994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-19 11:46:28 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…ds (#7445) (#7478) protectedFrontmatterFields listed every protected field in camelCase only, so an entry that wrote a protected field in the legitimately-accepted snake_case convention (e.g. download_url instead of downloadUrl) was invisible to protectedFrontmatterChanges — the gate compared before["downloadUrl"]/after["downloadUrl"], both undefined, saw no change, and the protected-close never fired even though the underlying value changed. Same divergence class as #7250 (urlFields vs sourceUrlFields), already fixed in this repo via PR #7269. This adds the 19 snake_case aliases for every multi-word camelCase member (author, category, disclosure, slug are single all-lowercase words and don't need one). Data-only addition to the Set; protectedFrontmatterChanges's comparison logic is untouched. Closes #7445
Summary
content-repo-spec.tsdefines two lists over the same concept — the manifest-entry keys that hold asource/provenance URL — but they had diverged:
urlFields(aSet, read byduplicates.ts) lists both camelCase and snake_case aliases(
sourceUrl/source_url,githubUrl/github_url, …).sourceUrlFields(an array, read bysource-evidence.ts) listed only the camelCase names.So a manifest entry using a legitimately-listed snake_case key — e.g.
source_url:, in fact the canonicalfield per the repo's contribution conventions — was seen by duplicate-detection but invisible to the
source-evidence gate.
This adds the eight snake_case aliases (
docs_url,download_url,github_url,package_url,repo_url,repository_url,source_url,website_url) tosourceUrlFields, matchingurlFields's existing pairingone-for-one. Data-only change to the spec constant; neither consumer's logic is touched. (
src/review/content-lane/content-repo-spec.tsis aexport *re-export shim, so the app sees the fix automatically.)Closes #7250
Scope
site//CNAME/lovable; no new dependency.Closes #7250).Validation
git diff --checknpm run typecheck(root — clean)npm run test:coverage— 100% of the changed lines covered. New regression: asource_url:frontmatterfield is now extracted by
extractSubmittedSourceUrls(it was dropped before), and every snake_case alias insourceUrlFieldsis asserted present in both lists. Existing content-lane duplicate/source-evidence suites pass unchanged.readonly string[]; both consumers' logic is untouched.If any required check was skipped, explain why:
packages/loopover-engine/src/review/content-lane/**(one constant + one test); CI runs the full suite incl. engine-parity.Safety