fix(review): restore engine-parity after gittensory rename drift - #5892
Merged
Conversation
PR #5883 renamed brand-name prose in src/review/guardrail-config.ts and src/review/linked-issue-label-propagation.ts but not their byte-identical twins under packages/loopover-engine/src/review/, breaking scripts/check-engine-parity.ts on main. Aligns the engine copies' comment text with the host copies. Also fixes a stale finding-taxonomy.test.ts assertion that still expected the pre-rename "gittensory://finding-taxonomy" MCP resource URI literal (the constant itself was already correctly renamed by #5883; only this test's hardcoded expectation had drifted).
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Closed
This was referenced Jul 14, 2026
This was referenced Jul 15, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/review/guardrail-config.tsandsrc/review/linked-issue-label-propagation.tsbut not their byte-identical twins underpackages/loopover-engine/src/review/**, whichscripts/check-engine-parity.tsrequires to stay in sync. This broke the parity check onmain(verified by cloning a freshmainand running the script directly — 2 real failures).test/unit/finding-taxonomy.test.ts, which had a stale hardcoded assertion still expecting the pre-rename"gittensory://finding-taxonomy"MCP resource URI literal — the constant itself (FINDING_TAXONOMY_URI) was already correctly renamed by docs(review): rename gittensory prose to loopover in src/review (batch A) #5883; only this one test's pinned expectation had drifted. Every other consumer of this constant imports the symbol, so nothing else was affected.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpx tsx scripts/check-engine-parity.ts— confirms ok (was failing onmainbefore this fix)npm run test:coverage— full unsharded run, 100% greennpm run test:cigate run locally, exit 0Safety
UI Evidencesection. — N/A, no UI changes.Notes
main, not part of the normal batched-PR sequence for epic Epic: complete the gittensory -> loopover rebrand (full cutover, no dual-support) #5705.