fix(miner): cap check-runs page follows so poll cannot spin forever - #10258
Merged
loopover-orb[bot] merged 1 commit intoJul 31, 2026
Merged
Conversation
…SONbored#10007) Add a normalized maxPages bound to fetchCheckRuns, mirroring opportunity-fanout, and throw a distinct page-cap error when a Link chain exceeds it.
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10258 +/- ##
==========================================
+ Coverage 80.60% 80.64% +0.03%
==========================================
Files 283 284 +1
Lines 59101 59215 +114
Branches 7000 7033 +33
==========================================
+ Hits 47641 47755 +114
Misses 11167 11167
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxPagestoPollCheckRunsOptions, normalized like the other poller bounds (default 10 → 1000 checks atper_page=100, clamped 1–100), mirroringopportunity-fanout's page-follow cap.fetchCheckRuns' unboundedwhile (true)withwhile (page <= maxPages); exceeding the cap throwsgithub_check_runs_pagination_page_capso a pathologicalrel="next"chain cannot wedgemanage poll/loop.github_check_runs_pagination_incompletebehavior are unchanged.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-miner/lib/ci-poller.tsviatest/unit/miner-ci-poller.test.ts+test/unit/miner-ci-poller-failure-modes.test.ts(100% lines / 100% branches on the file). Fulltest:ci/ UI / MCP packs deferred to CI for this miner-lib-only change.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI/frontend/docs changes.
Notes
github_check_runs_pagination_incompleteso operators can tell "server kept advertising more pages" from "empty page mid-stream".Made with Cursor