feat(selfhost): expand Sentry observability context for self-host runtime - #1881
feat(selfhost): expand Sentry observability context for self-host runtime#1881jonathanchang31 wants to merge 3 commits into
Conversation
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-06-30 19:17:11 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 6 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
I appreciate the work on this PR (selfhost is the most important focus area right now), but there are merge conflicts, and this PR seems to mix the concerns from 2 or more separate issues into a single one - there are also blockers in the review:
Blockers
src/selfhost/sentry.ts:18 makes the `review` key itself sensitive because `(text|body)?` is optional, so any event context named `review` from `captureReviewFailure` is replaced with `[redacted]` and the safe repo/PR context added at src/selfhost/sentry.ts:230 never reaches Sentry.
src/github/client.ts:289 now makes coalesced callers throw the leader's pre-response network error instead of doing their own fetch when no cached replay exists, so two simultaneous cacheable GETs can both fail from one transient leader failure even though the follower path previously succeeded.
Nits — 6 non-blocking
Why this is blocked
src/selfhost/sentry.ts:18 makes the `review` key itself sensitive because `(text|body)?` is optional, so any event context named `review` from `captureReviewFailure` is replaced with `[redacted]` and the safe repo/PR context added at src/selfhost/sentry.ts:230 never reaches Sentry.
Summary
Related Issue
Closes: #1824
Change Type
What Changed
src/selfhost/sentry.ts.Real Behavior Proof
npx vitest run test/unit/selfhost-sentry.test.ts test/unit/selfhost-monitored-work.test.tsnpm run test:cinpm audit --audit-level=moderateChecklist
SENTRY_DSNis unsetNotes