Skip to content

feat: add login-idp-link-email page#92

Merged
garronej merged 3 commits into
keycloakify:mainfrom
Tasyp:add-login-idp-link-email
Apr 25, 2022
Merged

feat: add login-idp-link-email page#92
garronej merged 3 commits into
keycloakify:mainfrom
Tasyp:add-login-idp-link-email

Conversation

@Tasyp
Copy link
Copy Markdown
Collaborator

@Tasyp Tasyp commented Apr 22, 2022

Adds login-idp-link-email.ftl page.

However, there is one issue. In the original template, the code looks like the following:

${msg("emailLinkIdp1", idpAlias, brokerContext.username, realm.displayName)}

Is it possible to somehow access the brokerContext inside kecloakify?

Copy link
Copy Markdown
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Tasyp,
Than you for your contribution!
Would you mind trying with the following suggestions?

Comment thread src/lib/components/LoginIdpLinkEmail.tsx Outdated
Comment thread src/lib/components/LoginIdpLinkEmail.tsx Outdated
Comment thread src/lib/getKcContext/KcContextBase.ts
@Tasyp
Copy link
Copy Markdown
Collaborator Author

Tasyp commented Apr 25, 2022

@garronej thanks for your quick feedback!

I have addressed your feedback. It should look good now

@garronej
Copy link
Copy Markdown
Collaborator

Looks great, thank you very much for your contribution, it is much appreciated.

@garronej garronej merged commit ac99e2f into keycloakify:main Apr 25, 2022
@garronej
Copy link
Copy Markdown
Collaborator

a new version incorporating your contribution has been released

@Tasyp Tasyp deleted the add-login-idp-link-email branch April 25, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants