Skip to content

Add all remaining modern spellbook spells#915

Open
GregHib wants to merge 24 commits intomainfrom
modern-spells
Open

Add all remaining modern spellbook spells#915
GregHib wants to merge 24 commits intomainfrom
modern-spells

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Mar 11, 2026

  • Fix not creating .temp folder
  • Fix spellbook sorting
  • Add alchemy
  • Add tele grab
  • Add bones to peaches/bananas
  • Add jewellery enchanting
  • Add bolt enchanting
  • Add ape atoll teleport

Closes #908

Todo:

  • Orb charging
  • Teleother

@github-actions
Copy link
Contributor

Qodana for JVM

7 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 5
Unused import directive 🔶 Warning 1
Duplicated code fragment ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 65.21739% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.51%. Comparing base (3066dc4) to head (f3d1623).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...content/skill/magic/book/modern/TelekineticGrab.kt 61.90% 7 Missing and 9 partials ⚠️
...in/content/entity/player/inv/item/take/ItemTake.kt 44.00% 8 Missing and 6 partials ⚠️
...ent/skill/magic/book/modern/EnchantCrossbowBolt.kt 78.12% 8 Missing and 6 partials ⚠️
.../kotlin/content/skill/magic/book/modern/Alchemy.kt 77.77% 2 Missing and 6 partials ⚠️
...ontent/skill/magic/book/modern/EnchantJewellery.kt 84.78% 4 Missing and 3 partials ⚠️
...lin/content/skill/magic/jewellery/GamesNecklace.kt 61.11% 4 Missing and 3 partials ⚠️
...s/voidps/engine/data/definition/EnumDefinitions.kt 0.00% 4 Missing ⚠️
...ontent/area/misthalin/barbarian_village/Dororan.kt 0.00% 4 Missing ⚠️
...in/content/entity/player/command/ServerCommands.kt 0.00% 4 Missing ⚠️
...ontent/minigame/pyramid_plunder/PharaohsSceptre.kt 63.63% 2 Missing and 2 partials ⚠️
... and 35 more
Additional details and impacted files
Files with missing lines Coverage Δ
...in/kotlin/content/area/kandarin/ardougne/Edmond.kt 57.59% <100.00%> (ø)
...in/content/area/misthalin/lumbridge/castle/Cook.kt 37.95% <100.00%> (ø)
...otlin/content/entity/player/equip/WornEquipment.kt 48.14% <100.00%> (+7.40%) ⬆️
...ntent/minigame/sorceress_garden/SorceressGarden.kt 42.42% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fishing/Fishing.kt 48.35% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fletching/Bolts.kt 65.21% <100.00%> (ø)
...e/src/main/kotlin/content/skill/fletching/Darts.kt 65.21% <100.00%> (ø)
...kotlin/content/skill/fletching/FletchUnfinished.kt 71.79% <100.00%> (ø)
...kotlin/content/skill/magic/book/lunar/CurePlant.kt 56.52% <100.00%> (ø)
...n/kotlin/content/skill/magic/book/modern/Charge.kt 56.25% <100.00%> (ø)
... and 48 more

... and 3 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #915      +/-   ##
============================================
+ Coverage     38.23%   38.51%   +0.27%     
- Complexity     7680     7760      +80     
============================================
  Files          1555     1560       +5     
  Lines         62523    62778     +255     
  Branches      15674    15714      +40     
============================================
+ Hits          23906    24177     +271     
+ Misses        33305    33198     -107     
- Partials       5312     5403      +91     
Components Coverage Δ
Content 36.72% <66.40%> (+0.45%) ⬆️
Engine 45.92% <50.00%> (-0.03%) ⬇️
Network 60.85% <ø> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add remaining modern spells

1 participant