Skip to content

Commit 28af88e

Browse files
wesmkou
authored andcommitted
ARROW-394: [Integration] Generate tests cases for numeric types, strings, lists, structs
Automatically generating testing files from Python. Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#219 from wesm/ARROW-394 and squashes the following commits: 7807f48 [Wes McKinney] OS X doesn't have std::fabs c0c804c [Wes McKinney] abs -> fabs 8cd1902 [Wes McKinney] Fix compiler warning in OS X from incorrect type declaration d51581a [Wes McKinney] Add missing apache license 527622d [Wes McKinney] ARROW-414: remove check for maximum buffer padding 2a7b0fc [Wes McKinney] Add JSON generation code to fuzz test numeric types, print integers more nicely. Add integration tests to Travis CI build matrix. Add ApproxEquals method for floating point comparisons. Add boolean, string, struct, list to generated json test case
1 parent e476ff0 commit 28af88e

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

vector/src/main/java/org/apache/arrow/vector/BaseDataValueVector.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ public abstract class BaseDataValueVector extends BaseValueVector implements Buf
3030

3131
protected final static byte[] emptyByteArray = new byte[]{}; // Nullable vectors use this
3232

33-
/** maximum extra size at the end of the buffer */
34-
private static final int MAX_BUFFER_PADDING = 64;
35-
3633
public static void load(ArrowFieldNode fieldNode, List<BufferBacked> vectors, List<ArrowBuf> buffers) {
3734
int expectedSize = vectors.size();
3835
if (buffers.size() != expectedSize) {
@@ -51,9 +48,6 @@ public static void truncateBufferBasedOnSize(List<ArrowBuf> buffers, int bufferI
5148
if (buffer.writerIndex() < byteSize) {
5249
throw new IllegalArgumentException("can not truncate buffer to a larger size " + byteSize + ": " + buffer.writerIndex());
5350
}
54-
if (buffer.writerIndex() - byteSize > MAX_BUFFER_PADDING) {
55-
throw new IllegalArgumentException("Buffer too large to resize to " + byteSize + ": " + buffer.writerIndex());
56-
}
5751
buffer.writerIndex(byteSize);
5852
}
5953

0 commit comments

Comments
 (0)