fix(release): give crates explicit versions for release-please#129
Merged
Conversation
release-please's Rust workspace strategy versions each member crate in its own Cargo.toml and cannot rewrite an inherited `version.workspace = true`, so it failed with 'value at path package.version is not tagged'. Give each of the five crates an explicit version = "0.3.9" (kept in lockstep by release-please) and drop the now-unused [workspace.package].version. Inter-crate deps are path-only, so no version requirements need syncing.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe workspace-level ChangesPer-crate version pinning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Release Pleaseworkflow, which failed withvalue at path package.version is not tagged. release-please's Rust workspace strategy versions each member crate in its ownCargo.tomland cannot rewrite an inheritedversion.workspace = true.Motivation & context
After #127 merged, the release-please run on
mainerrored:✔ found workspace with 5 members, upgrading all
Error: release-please failed: value at path package.version is not tagged
The root
Cargo.tomlis a virtual workspace and all five crates inheritversion.workspace = true, so there is no literal version string for the Rust updater to bump.Closes #
Kind of change
What changed
Cargo.toml: removed[workspace.package].version(no longer the source of truth).gitlawb-core,gitlawb-node,gl,git-remote-gitlawb,gitlawb-attest): replacedversion.workspace = truewith explicitversion = "0.3.9"; they still inheritedition/rust-version/license/authors/repositoryfrom the workspace.Cargo.lock. Inter-crate deps uirement), so nothing else needs syncing.How a reviewer can verify