Skip to content

fix: em dash rendering in StagingBanner component#92

Merged
FSM1 merged 2 commits into
mainfrom
claude/fix-staging-banner-unicode-PmS4l
Feb 11, 2026
Merged

fix: em dash rendering in StagingBanner component#92
FSM1 merged 2 commits into
mainfrom
claude/fix-staging-banner-unicode-PmS4l

Conversation

@FSM1

@FSM1 FSM1 commented Feb 11, 2026

Copy link
Copy Markdown
Owner

Summary

Fixed the rendering of the em dash character in the StagingBanner component by wrapping it in a string literal to ensure proper display.

Changes

  • Wrapped the em dash Unicode character (\u2014) in quotes within the JSX expression in the StagingBanner component
  • This ensures the em dash is properly rendered as a string rather than being interpreted as a raw Unicode escape sequence

Details

The em dash character in the staging banner message was changed from \u2014 to {'\u2014'} to maintain consistency with how other Unicode characters (the warning symbols \u26A0) are handled in the same string. This guarantees proper rendering across different environments and browsers.

https://claude.ai/code/session_01Bwf9t5aAQ8GzQbUhetRA2X

Summary by CodeRabbit

  • Style
    • Refactored internal formatting in the staging banner component with no visible changes to end-users.

The em dash \u2014 was bare text in JSX, which doesn't process
JS unicode escapes. Wrap it in a JSX expression {'\u2014'} to
match the existing pattern used for the warning symbols.

https://claude.ai/code/session_01Bwf9t5aAQ8GzQbUhetRA2X
@FSM1 FSM1 changed the title Fix em dash rendering in StagingBanner component fix: em dash rendering in StagingBanner component Feb 11, 2026
@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown

Walkthrough

This pull request modifies the StagingBanner component's compact variant by extracting the em dash character from the label string into a separate JSX expression ({'\u2014'}). The visual output remains unchanged.

Changes

Cohort / File(s) Summary
Compact Variant Label Formatting
apps/web/src/components/StagingBanner.tsx
Extracted em dash from inline string to separate JSX expression in compact variant label, maintaining visual output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: wrapping the em dash in a string literal to fix its rendering in the StagingBanner component.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-staging-banner-unicode-PmS4l

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@FSM1 FSM1 enabled auto-merge (squash) February 11, 2026 01:15
@FSM1 FSM1 disabled auto-merge February 11, 2026 01:15
@FSM1 FSM1 merged commit 6bd93ee into main Feb 11, 2026
7 checks passed
@FSM1 FSM1 deleted the claude/fix-staging-banner-unicode-PmS4l branch February 11, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants