fix: em dash rendering in StagingBanner component#92
Merged
Conversation
The em dash \u2014 was bare text in JSX, which doesn't process
JS unicode escapes. Wrap it in a JSX expression {'\u2014'} to
match the existing pattern used for the warning symbols.
https://claude.ai/code/session_01Bwf9t5aAQ8GzQbUhetRA2X
WalkthroughThis pull request modifies the StagingBanner component's compact variant by extracting the em dash character from the label string into a separate JSX expression ({'\u2014'}). The visual output remains unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the rendering of the em dash character in the StagingBanner component by wrapping it in a string literal to ensure proper display.
Changes
\u2014) in quotes within the JSX expression in the StagingBanner componentDetails
The em dash character in the staging banner message was changed from
\u2014to{'\u2014'}to maintain consistency with how other Unicode characters (the warning symbols\u26A0) are handled in the same string. This guarantees proper rendering across different environments and browsers.https://claude.ai/code/session_01Bwf9t5aAQ8GzQbUhetRA2X
Summary by CodeRabbit