fix: file browser scrolling and layout overflow issues#89
Merged
Conversation
The file list page was scrolling the entire main content area when there were many files, which caused the toolbar (breadcrumbs, action buttons, sync indicator) to scroll out of view. Now only the file list body scrolls while the toolbar and header remain fixed on screen. - Add overflow: hidden to .file-browser-content to contain overflow - Add flex: 1 and min-height: 0 to .file-list so it fills remaining space - Add overflow-y: auto to .file-list-body for isolated scroll https://claude.ai/code/session_01BCBTX9Dk4k9WVcfWUKvqmD
WalkthroughUpdated CSS layout properties in the file browser stylesheet to improve flex container behavior. Added overflow constraints and flex growth rules to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the file browser’s flex/overflow CSS so the file list can scroll correctly within a constrained layout, avoiding page-level overflow.
Changes:
- Set the main
.file-browser-contentcontainer tooverflow: hiddento prevent unintended overflow outside the file browser area. - Updated
.file-listand.file-list-bodywithflex: 1andmin-height: 0to allow flex shrinking and enable inner scrolling. - Enabled vertical scrolling on
.file-list-bodyviaoverflow-y: auto.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
FSM1
changed the title
FSM1
changed the title
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed layout and scrolling issues in the file browser component by properly configuring flex containers and overflow behavior.
Key Changes
overflow: hiddento the main file browser container to prevent unintended overflow.file-listwithflex: 1andmin-height: 0to allow proper flex shrinking and enable scrolling in child elements.file-list-bodywith:flex: 1to fill available spacemin-height: 0to enable scrolling within flex containersoverflow-y: autoto enable vertical scrolling for file itemsImplementation Details
These changes follow the CSS flexbox pattern for scrollable containers within flex layouts. The
min-height: 0property is necessary to allow flex items to shrink below their content size, which is required for scrolling to work properly in nested flex containers. This ensures the file list can scroll independently while maintaining the overall layout structure.https://claude.ai/code/session_01BCBTX9Dk4k9WVcfWUKvqmD
Summary by CodeRabbit