fix: unpin orphaned IPFS CIDs on failed folder registration

[FSM1]

Summary

• When upload() succeeds but addFiles() fails (e.g., duplicate filename, network error), the already-pinned CIDs are now cleaned up via fire-and-forget unpin calls
• Quota is refreshed after cleanup so the UI reflects correct usage
• Applies to both UploadZone and EmptyState components
• Confirms todo Initial PRD attempt #1 (registering state stuck) was already fixed; moves both resolved todos to done/

Test plan

• Upload a file with a duplicate name — verify the error is shown and quota does not increase
• Simulate addFiles failure (e.g., disconnect network after upload completes) — verify CIDs are unpinned
• Verify normal upload flow still works end-to-end
• Verify quota refreshes correctly after cleanup

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved file upload error handling to prevent orphaned files in storage; failed uploads now trigger cleanup of uploaded artifacts and refresh quota when appropriate.
• Tests
  • Added tests covering upload error recovery, orphaned-file cleanup, quota refresh, cancellation paths, and resilience to cleanup failures.

[coderabbitai]

Warning

Rate limit exceeded

@FSM1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

Upload components now track uploaded files and perform cleanup (unpin from IPFS and refresh quota) when an upload fails after files were pinned; a new test suite covers error-recovery and orphaned-pin cleanup behaviors.

Changes

Cohort / File(s)	Summary
Upload components apps/web/src/components/file-browser/EmptyState.tsx, apps/web/src/components/file-browser/UploadZone.tsx	Add uploadedFiles tracking; assign upload result to it; on post-upload errors unpin each uploaded CID via unpinFromIpfs and refresh quota via useQuotaStore.
Tests apps/web/src/stores/__tests__/upload-error-recovery.test.ts	New test suite validating error transitions, orphaned-pin cleanup (unpin + quota refresh), handling when uploadedFiles is undefined, user-cancelled uploads, and non-blocking unpin failures.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant UI as UI Component
participant UploadSvc as Upload Service
participant IPFS as IPFS (unpinFromIpfs)
participant Quota as Quota Store
UI->>UploadSvc: start upload(acceptedFiles)
UploadSvc-->>UI: uploadedFiles (success) / error
alt upload succeeds then registration fails
UI->>IPFS: unpinFromIpfs(cid) for each uploaded file
IPFS-->>UI: ack / error
UI->>Quota: fetchQuota()
Quota-->>UI: updated quota
UI-->>UI: set error state
else upload fails before any pins
UI-->>UI: set error state (no unpin, no quota refresh)
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}