fix(web): use static import for vault store in __E2E helpers#303
Merged
Conversation
The dynamic import().then() created a race condition — __E2E was undefined when conflict-detection tests read it because the async import hadn't resolved yet. Switch to static import since Vite dead-code-eliminates the entire VITE_E2E block (including unused imports) in production builds anyway. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: a1b1e020ce59
|
Caution Review failedPull request was closed or merged during review WalkthroughThe change converts a dynamic import of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Mar 21, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dynamic
import('./stores/vault.store').then()inmain.tsxcreated a race condition —window.__E2Ewasundefinedwhen conflict-detection tests calledpage.evaluate()inbeforeAllbecause the async import hadn't resolved yet.Switched to a static import. Vite dead-code-eliminates the entire
VITE_E2Eblock (including the unused import) in production builds where the flag isn't set.Test plan
__E2E.getAccessToken()no longer throws)VITE_E2Eunset)🤖 Generated with Claude Code
Summary by CodeRabbit