fix(web): remove isLoaded check from ensureFolderRegistered guard#301
Conversation
The isLoaded flag isn't set in all code paths (e.g., SDK-created folders, root folder after init). The guard only needs to check for empty key material — if folderKey and ipnsPrivateKey have content, the folder is safe to register regardless of the isLoaded flag. This was causing "Folder not loaded" errors in E2E tests because ensureFolderRegistered silently skipped registration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: e2ed6ed73904
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
isLoadedflag in theensureFolderRegisteredguard (added in PR feat: extract core crypto SDK as shared packages #296 review fixes) was too strict — it's not set in all code paths (e.g., SDK-created folders, root folder after vault init)ensureFolderRegisteredto silently skip registration, leading to "Folder not loaded" errors on upload/create operationsfolderKey.length === 0 || ipnsPrivateKey.length === 0), which is the actual safety conditionTest plan
🤖 Generated with Claude Code