Skip to content

fix(ci): use explicit SHA for paths-filter ref in desktop E2E#244

Merged
FSM1 merged 1 commit into
mainfrom
fix/desktop-e2e-paths-filter-ref
Mar 2, 2026
Merged

fix(ci): use explicit SHA for paths-filter ref in desktop E2E#244
FSM1 merged 1 commit into
mainfrom
fix/desktop-e2e-paths-filter-ref

Conversation

@FSM1

@FSM1 FSM1 commented Mar 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • ref: HEAD fails in paths-filter because it does git show-ref HEAD which finds no match in detached HEAD state
  • Use github.event.workflow_run.head_sha (the actual commit SHA) for both base parent resolution and ref

Test plan

  • Merge and verify the desktop E2E Detect Changes job passes

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

No user-facing changes. This release includes an internal infrastructure update to the CI/CD workflow configuration that optimizes test execution paths. End-users will not be affected by these changes.

paths-filter can't resolve `ref: HEAD` in detached HEAD state — it
does `git show-ref HEAD` which finds no match. Use the actual commit
SHA from the workflow_run event instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 5c2c3236af59
@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9115263 and 0b47133.

📒 Files selected for processing (1)
  • .github/workflows/e2e-desktop.yml

Walkthrough

A single line in the e2e-desktop GitHub Actions workflow was modified to change the ref value used by the paths-filter step from HEAD to ${{ github.event.workflow_run.head_sha }}. This alters which commit serves as the reference for filtering changed files without affecting other workflow logic.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/e2e-desktop.yml
Modified the ref parameter in the paths-filter step to use the workflow run's head SHA instead of HEAD, changing the base commit reference for path filtering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: using an explicit SHA for the paths-filter ref in the desktop E2E workflow to fix a detached HEAD issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/desktop-e2e-paths-filter-ref

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FSM1 FSM1 merged commit 24570e8 into main Mar 2, 2026
21 checks passed
@FSM1 FSM1 deleted the fix/desktop-e2e-paths-filter-ref branch March 4, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant