fix(docker): add database name to postgres healthcheck#116
Merged
Conversation
pg_isready without -d defaults to connecting to a database matching
the username ("cipherbox"), which doesn't exist on staging where the
database is "cipherbox_staging". This caused FATAL log spam every 5s.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughModified the postgres healthcheck configuration in the staging docker-compose file to use a multiline array format and explicitly specify the target database using the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-d ${DB_DATABASE:-cipherbox_staging}to the postgres healthcheckpg_isreadycommand in the staging compose file-d,pg_isreadydefaults to connecting to a database matching the username (cipherbox), which doesn't exist on staging — the actual database iscipherbox_stagingFATAL: database "cipherbox" does not existlog spam every 5 secondsTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit