From 2aa1e38f0e896ba11fc879f8b8f99fcede139055 Mon Sep 17 00:00:00 2001 From: Situ Chandra Shil <108292595+situchan@users.noreply.github.com> Date: Thu, 27 Nov 2025 08:50:07 +1100 Subject: [PATCH] Revert "Update approval mode in upgrade" --- .../workspace/members/ImportedMembersPage.tsx | 6 +++++ .../upgrade/WorkspaceUpgradePage.tsx | 25 ++++++------------- .../workflows/WorkspaceWorkflowsPage.tsx | 2 +- 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/src/pages/workspace/members/ImportedMembersPage.tsx b/src/pages/workspace/members/ImportedMembersPage.tsx index b5f11c2fc2fe..03ff457ad966 100644 --- a/src/pages/workspace/members/ImportedMembersPage.tsx +++ b/src/pages/workspace/members/ImportedMembersPage.tsx @@ -79,6 +79,7 @@ function ImportedMembersPage({route}: ImportedMembersPageProps) { const columns = Object.values(spreadsheet?.columns ?? {}); + const containsAdvanceApprovalColumns = columns.includes(CONST.CSV_IMPORT_COLUMNS.SUBMIT_TO) || columns.includes(CONST.CSV_IMPORT_COLUMNS.APPROVE_TO); const membersRolesColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.ROLE); const hasAuditorRole = membersRolesColumn !== -1 && @@ -86,6 +87,11 @@ function ImportedMembersPage({route}: ImportedMembersPageProps) { ?.at(membersRolesColumn) ?.some((role, index) => (containsHeader ? spreadsheet?.data?.at(membersRolesColumn)?.at(index + 1) : (role ?? '')) === CONST.POLICY.ROLE.AUDITOR); + if (containsAdvanceApprovalColumns && !isControlPolicy(policy)) { + Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(route.params.policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, Navigation.getActiveRoute())); + return; + } + if (hasAuditorRole && !isControlPolicy(policy)) { Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(route.params.policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.auditor.alias, Navigation.getActiveRoute())); return; diff --git a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx index 1ecb31527aae..eef1a495708d 100644 --- a/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx +++ b/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx @@ -14,18 +14,11 @@ import {updateXeroMappings} from '@libs/actions/connections/Xero'; import Navigation from '@libs/Navigation/Navigation'; import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types'; import type {SettingsNavigatorParamList} from '@libs/Navigation/types'; -import {canModifyPlan, getDefaultApprover, getPerDiemCustomUnit, isControlPolicy} from '@libs/PolicyUtils'; +import {canModifyPlan, getPerDiemCustomUnit, isControlPolicy} from '@libs/PolicyUtils'; import NotFoundPage from '@pages/ErrorPage/NotFoundPage'; import {enablePerDiem} from '@userActions/Policy/PerDiem'; import CONST from '@src/CONST'; -import { - enableCompanyCards, - enablePolicyReportFields, - enablePolicyRules, - setPolicyPreventMemberCreatedTitle, - setWorkspaceApprovalMode, - upgradeToCorporate, -} from '@src/libs/actions/Policy/Policy'; +import {enableCompanyCards, enablePolicyReportFields, enablePolicyRules, setPolicyPreventMemberCreatedTitle, upgradeToCorporate} from '@src/libs/actions/Policy/Policy'; import ONYXKEYS from '@src/ONYXKEYS'; import ROUTES from '@src/ROUTES'; import type SCREENS from '@src/SCREENS'; @@ -168,22 +161,20 @@ function WorkspaceUpgradePage({route}: WorkspaceUpgradePageProps) { case CONST.UPGRADE_FEATURE_INTRO_MAPPING.perDiem.id: enablePerDiem(policyID, true, perDiemCustomUnit?.customUnitID, false); break; - case CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.id: - setWorkspaceApprovalMode(policyID, getDefaultApprover(policy), CONST.POLICY.APPROVAL_MODE.ADVANCED); - break; default: } }, [ - policyID, + categoryId, feature, - featureNameAlias, - route.params.featureName, perDiemCustomUnit?.customUnitID, - policy, + policy?.connections?.xero?.config, + policy?.connections?.xero?.data, + policyID, qboConfig?.syncClasses, qboConfig?.syncCustomers, qboConfig?.syncLocations, - categoryId, + route.params?.featureName, + featureNameAlias, ]); useFocusEffect( diff --git a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx index b955c257a4cb..2afa6ccc1ba1 100644 --- a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx +++ b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx @@ -100,7 +100,7 @@ function WorkspaceWorkflowsPage({policy, route}: WorkspaceWorkflowsPageProps) { const hasValidExistingAccounts = getEligibleExistingBusinessBankAccounts(bankAccountList, policy?.outputCurrency).length > 0; - const isAdvanceApproval = (approvalWorkflows.length > 1 || (approvalWorkflows?.at(0)?.approvers ?? []).length > 1) && isControlPolicy(policy); + const isAdvanceApproval = approvalWorkflows.length > 1 || (approvalWorkflows?.at(0)?.approvers ?? []).length > 1; const updateApprovalMode = isAdvanceApproval ? CONST.POLICY.APPROVAL_MODE.ADVANCED : CONST.POLICY.APPROVAL_MODE.BASIC; const displayNameForAuthorizedPayer = useMemo( () => getPersonalDetailByEmail(policy?.achAccount?.reimburser ?? '')?.displayName ?? policy?.achAccount?.reimburser,