From cb4cf0b42249f27c0dde166887d47fef1a3c9802 Mon Sep 17 00:00:00 2001 From: Ionatan Wiznia Date: Thu, 24 Apr 2025 18:54:41 +0200 Subject: [PATCH 1/2] Add canBeMissing item to checklist --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b8de634a489f..420b9cb942bd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -87,6 +87,7 @@ This is a checklist for PR authors. Please make sure to complete all tasks and c - [ ] MacOS: Chrome / Safari - [ ] MacOS: Desktop - [ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) +- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx` - [ ] I followed proper code patterns (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`) - [ ] I verified that comments were added to code that is not self explanatory From 018608b49364cf029b01180e772ae55f49a60a61 Mon Sep 17 00:00:00 2001 From: Ionatan Wiznia Date: Thu, 24 Apr 2025 11:08:31 -0600 Subject: [PATCH 2/2] Add to reviewer --- contributingGuides/REVIEWER_CHECKLIST.md | 1 + 1 file changed, 1 insertion(+) diff --git a/contributingGuides/REVIEWER_CHECKLIST.md b/contributingGuides/REVIEWER_CHECKLIST.md index ab4b215516b9..654b869c6e68 100644 --- a/contributingGuides/REVIEWER_CHECKLIST.md +++ b/contributingGuides/REVIEWER_CHECKLIST.md @@ -17,6 +17,7 @@ - [ ] MacOS: Chrome / Safari - [ ] MacOS: Desktop - [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack +- [ ] I verified there are no new alerts related to the `canBeMissing` param for `useOnyx` - [ ] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`). - [ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. `myBool && `.