From 250e5b12eb43062057c97ba45043e72414c47732 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Tue, 26 Nov 2024 14:05:23 +0100 Subject: [PATCH 1/2] Add reasons why to skip tests --- tests/README.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/README.md b/tests/README.md index 08df0b89794b..20f3d0b4215b 100644 --- a/tests/README.md +++ b/tests/README.md @@ -100,7 +100,16 @@ The format looks like this: Many of the UI features of our application should go through rigorous testing by you, your PR reviewer, and finally QA before deployment. However, the code is mature enough now that protecting code against regressions is the top priority. -**What's a "good reason" to write a test?** +**What's a "good reason" to skip writing a test?** + +- App build configurations +- Changes to Github actions (for now) +- Copy changes +- Help site changes +- Style changes (for now) +- When fixing a deploy blocker, it's OK to not include the automated tests in the blocker-fixing PR, but make sure to follow up in a separate PR once the deploy blocker is resolved + +**What changes to definitely cover by tests?** - Any PR that fixes a bug - When introducing a new feature, cover as much logic as possible by unit tests From 022d52e8290c498478b53fd72d3c02135e5f98ab Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Tue, 26 Nov 2024 14:12:41 +0100 Subject: [PATCH 2/2] Update proposal template --- contributingGuides/PROPOSAL_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributingGuides/PROPOSAL_TEMPLATE.md b/contributingGuides/PROPOSAL_TEMPLATE.md index ea908b5b0666..d5ab0bf4a864 100644 --- a/contributingGuides/PROPOSAL_TEMPLATE.md +++ b/contributingGuides/PROPOSAL_TEMPLATE.md @@ -7,8 +7,8 @@ ### What changes do you think we should make in order to solve the problem? -### What specific scenarios should we cover in unit tests to prevent reintroducing this issue in the future? - +### What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future? + ### What alternative solutions did you explore? (Optional)