From e6e6fe32d15843a6e2e75048a23ede4f16b32667 Mon Sep 17 00:00:00 2001 From: Nikki Wines Date: Sun, 3 Dec 2023 00:00:57 -0800 Subject: [PATCH 1/3] loosely check bank name instead of requiring exact match --- src/components/Icon/BankIcons.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/Icon/BankIcons.ts b/src/components/Icon/BankIcons.ts index 81e9075091c6..9dab708a13bc 100644 --- a/src/components/Icon/BankIcons.ts +++ b/src/components/Icon/BankIcons.ts @@ -95,7 +95,11 @@ function getAssetIcon(bankNameKey: BankNameKey, isCard: boolean): React.FC value?.toLowerCase() === bankName); + const bank = Object.entries(CONST.BANK_NAMES).find(([, value]) => { + const condensedValue = value.replace(/\s/g, ''); + return bankName === value || bankName.includes(value) || bankName.startsWith(value) || + bankName === condensedValue || bankName.includes(condensedValue) || bankName.startsWith(condensedValue); + }); return (bank?.[0] as BankNameKey) ?? ''; } From 3430a75eb107c93906c45c7cbb247cd2b2f3c686 Mon Sep 17 00:00:00 2001 From: Nikki Wines Date: Sun, 3 Dec 2023 00:01:11 -0800 Subject: [PATCH 2/3] add mapping for hungtington national --- src/CONST.ts | 1 + src/components/Icon/BankIcons.ts | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/CONST.ts b/src/CONST.ts index 13b79179f431..43921d9a4457 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -2873,6 +2873,7 @@ const CONST = { FIDELITY: 'fidelity', GENERIC_BANK: 'generic bank', HUNTINGTON_BANK: 'huntington bank', + HUNTINGTON_NATIONAL: 'huntington national', NAVY_FEDERAL_CREDIT_UNION: 'navy federal credit union', PNC: 'pnc', REGIONS_BANK: 'regions bank', diff --git a/src/components/Icon/BankIcons.ts b/src/components/Icon/BankIcons.ts index 9dab708a13bc..d4401184783b 100644 --- a/src/components/Icon/BankIcons.ts +++ b/src/components/Icon/BankIcons.ts @@ -62,6 +62,9 @@ function getAssetIcon(bankNameKey: BankNameKey, isCard: boolean): React.FC) : (require('@assets/images/bankicons/huntington-bank.svg').default as React.FC), + [CONST.BANK_NAMES.HUNTINGTON_NATIONAL]: isCard + ? (require('@assets/images/cardicons/huntington-bank.svg').default as React.FC) + : (require('@assets/images/bankicons/huntington-bank.svg').default as React.FC), [CONST.BANK_NAMES.NAVY_FEDERAL_CREDIT_UNION]: isCard ? (require('@assets/images/cardicons/navy-federal-credit-union.svg').default as React.FC) : (require('@assets/images/bankicons/navy-federal-credit-union.svg').default as React.FC), From 10aef7ca5a53e2bfa8d6ad30192c5ef70d449cfd Mon Sep 17 00:00:00 2001 From: Nikki Wines Date: Sun, 3 Dec 2023 00:40:13 -0800 Subject: [PATCH 3/3] prettier --- src/components/Icon/BankIcons.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/components/Icon/BankIcons.ts b/src/components/Icon/BankIcons.ts index d4401184783b..ece9a865629b 100644 --- a/src/components/Icon/BankIcons.ts +++ b/src/components/Icon/BankIcons.ts @@ -99,9 +99,15 @@ function getAssetIcon(bankNameKey: BankNameKey, isCard: boolean): React.FC { - const condensedValue = value.replace(/\s/g, ''); - return bankName === value || bankName.includes(value) || bankName.startsWith(value) || - bankName === condensedValue || bankName.includes(condensedValue) || bankName.startsWith(condensedValue); + const condensedValue = value.replace(/\s/g, ''); + return ( + bankName === value || + bankName.includes(value) || + bankName.startsWith(value) || + bankName === condensedValue || + bankName.includes(condensedValue) || + bankName.startsWith(condensedValue) + ); }); return (bank?.[0] as BankNameKey) ?? ''; }