Skip to content

Fix MusicXML Slurs and Reworked Repeats#898

Merged
Danielku15 merged 5 commits into
developfrom
feature/music-xml-load-error
Jun 12, 2022
Merged

Fix MusicXML Slurs and Reworked Repeats#898
Danielku15 merged 5 commits into
developfrom
feature/music-xml-load-error

Conversation

@Danielku15
Copy link
Copy Markdown
Member

Issues

Fixes #865

Proposed changes

  • Extended MusicXML Tests to perform serialization/deserialization to detect potential errors
  • Fixed slur handling which caused some errors
  • Reworked handling of repeats to align with correct display/playback of GuitarPro (MusicXML tests reported some problematic handling of repeat groups and repeats in general).

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jun 12, 2022
@Danielku15 Danielku15 merged commit 3ce95b8 into develop Jun 12, 2022
@Danielku15 Danielku15 deleted the feature/music-xml-load-error branch June 12, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MusicXML loading error (slurred notes relevant)

1 participant