TabBrushGlyph have Bug: when 6str Note heighter than 5str Will happen

[goodgame365]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

the erro like:

Expected Behavior

The right one should be like this

Steps To Reproduce

the err file here
sb.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.2

Platform

Node.js

Environment

- **Browser**:chrome

Anything else?

I found
TabBrushGlyph.ts on 24 line begin may be wrong:

  let startY: number =
        cy + this.x + (tabBarRenderer.getNoteY(this._beat.maxNote!, NoteYPosition.Top));
    let endY: number =
        cy + this.y + tabBarRenderer.getNoteY(this._beat.minNote!, NoteYPosition.Bottom);

---

this._beat.maxNote! and this._beat.minNote! is erro Should be changed to

---

this._beat.maxStringNote! and this._beat.minStringNote!

---

Complete code：

---

  let startY: number =
        cy + this.x + (tabBarRenderer.getNoteY(this._beat.maxNote!, NoteYPosition.Top));
    let endY: number =
        cy + this.y + tabBarRenderer.getNoteY(this._beat.minStringNote!, NoteYPosition.Bottom);

---

[Danielku15]

Your findings were pointing in the right direction, we have to choose the notes for brushes based on the highest/lowest string, not the note height. Especially on tunings like ukulele it can easily be that a higher string is a lower note resulting in wrong brush strokes.