Skip to content

Beat RemoveNote function not working correctly #932

@gallegretti

Description

@gallegretti

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently when calling the removeNote function from a Beat, the noteStringLookup is not correctly updated: The reference is not removed from the map, which can causes other methods like getNoteOnString and hasNoteOnString to return incorrect values.

Expected Behavior

The removeNote function should remove the note from the noteStringLookup reference.

Steps To Reproduce

  1. Load a score
  2. Use removeNote in a beat with a valid note
  3. Use getNoteOnString with the string of the previous note.
  4. The return should be null but still is the removed note

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.3-alpha

Platform

Web

Environment

- **OS**: Windows 10 Pro
- **Browser**: Chrome 103.0.5060.134

Anything else?

No response

Metadata

Metadata

Assignees

Labels

area-coreRelated to some core parts of alphaTabplatform-allAffects all platformsstate-acceptedThis is a valid topic to work on.

Type

No type
No fields configured for issues without a type.

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions