Skip to content

Grace Notes should utilize the empty pre-beat space #1093

@Danielku15

Description

@Danielku15

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

As discussed here grace notes currently are placed before any pre-beat glyphs of a beat. Staves might reserve space for their pre-beats and if the staff showing grace notes doesn't have any pre beat glyphs, quite some space might be wasted.

Expected Behavior

If possible the grace notes should not consider the cross-staff pre-beat space, but really use the space reserved by the current staff.

Steps To Reproduce

  1. use this file and render all tracks GracePosition.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.3-alpha

Platform

Web

Environment

Not relevant in this case

Anything else?

We have to be careful not to mess up the positioning of grace notes across different bar renderers (e.g. tabs & score). Even though we might shift score grace notes closer to the note afterwards when there are no tabs, we still need to be sure potential other glyphs aligned with the grace notes are placed correct (tab notes, vibratos etc.)

Metadata

Metadata

Assignees

Labels

area-renderingEverything related to the renderingplatform-allAffects all platformsstate-acceptedThis is a valid topic to work on.

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions