[local_auth] Convert to Kotlin gradle for the plugin build files (flutter#11169)

stuartmorgan-g · web-flow · commit b3a69599c7b8 · 2026-03-18T20:24:23.000Z
Following up from flutter#11127, this is the initial example of converting a plugin build, rather than an example app build, to Kotlin gradle. This conversion was done manually, but closely referencing the current plugin template files. It differs mostly in not having the parts that are specific to the use of Kotlin source files, since `local_auth` is still Java-only. Later (when we start adopting Kotlin Pigeon generation everywhere, for instance) some of the diffs relative to the template files will go away. Unlike flutter#11127 this did not require tool changes, as it turns out that the previous changes were enough to handle these files, but I did add more tests. As with flutter#11127 I did not attempt to comprehensively duplicate all Groovy tests, since we should be able to relatively quickly convert everything in the repo, and then pull out the Groovy support and update all the tests to Kotlin. Note that this does *not* convert the plugin's example app to Kotlin gradle, only the plugin itself. The example app for plugins are non-trivial enough (due to native tests) that they should be converted separately. This has the bonus effect of validating that the plugin migration didn't require any changes in the client app. Part of flutter/flutter#176065 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
diff --git a/packages/local_auth/local_auth_android/CHANGELOG.md b/packages/local_auth/local_auth_android/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 2.0.7
+
+* Updates build files from Groovy to Kotlin.
+
 ## 2.0.6
 
 * Bumps androidx.core:core from 1.17.0 to 1.18.0.
diff --git a/packages/local_auth/local_auth_android/android/build.gradle.kts b/packages/local_auth/local_auth_android/android/build.gradle.kts
@@ -1,5 +1,5 @@
-group = 'io.flutter.plugins.localauth'
-version = '1.0-SNAPSHOT'
+group = "io.flutter.plugins.localauth"
+version = "1.0-SNAPSHOT"
 
 buildscript {
     repositories {
@@ -8,7 +8,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.13.1'
+        classpath("com.android.tools.build:gradle:8.13.1")
     }
 }
 
@@ -19,37 +19,40 @@ rootProject.allprojects {
     }
 }
 
-apply plugin: 'com.android.library'
+plugins {
+    id("com.android.library")
+}
 
 android {
     namespace = "io.flutter.plugins.localauth"
     compileSdk = flutter.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion 24
-        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+        minSdk = 24
+        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
     }
 
     compileOptions {
         sourceCompatibility = JavaVersion.VERSION_17
         targetCompatibility = JavaVersion.VERSION_17
     }
 
-    lintOptions {
+    lint {
         checkAllWarnings = true
         warningsAsErrors = true
-        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency', 'NewerVersionAvailable'
+        disable.addAll(setOf("AndroidGradlePluginVersion", "InvalidPackage", "GradleDependency", "NewerVersionAvailable"))
     }
 
-
     testOptions {
-        unitTests.includeAndroidResources = true
-        unitTests.returnDefaultValues = true
-        unitTests.all {
-            testLogging {
-               events "passed", "skipped", "failed", "standardOut", "standardError"
-               outputs.upToDateWhen {false}
-               showStandardStreams = true
+        unitTests {
+            isIncludeAndroidResources = true
+            isReturnDefaultValues = true
+            all {
+                it.outputs.upToDateWhen { false }
+                it.testLogging {
+                    events("passed", "skipped", "failed", "standardOut", "standardError")
+                    showStandardStreams = true
+                }
             }
         }
     }
diff --git a/packages/local_auth/local_auth_android/android/settings.gradle b/packages/local_auth/local_auth_android/android/settings.gradle
diff --git a/packages/local_auth/local_auth_android/android/settings.gradle.kts b/packages/local_auth/local_auth_android/android/settings.gradle.kts
@@ -0,0 +1 @@
+rootProject.name = "local_auth"
diff --git a/packages/local_auth/local_auth_android/pubspec.yaml b/packages/local_auth/local_auth_android/pubspec.yaml
@@ -2,7 +2,7 @@ name: local_auth_android
 description: Android implementation of the local_auth plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/local_auth/local_auth_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+local_auth%22
-version: 2.0.6
+version: 2.0.7
 
 environment:
   sdk: ^3.9.0
diff --git a/script/tool/test/gradle_check_command_test.dart b/script/tool/test/gradle_check_command_test.dart
@@ -19,6 +19,8 @@ void main() {
   late Directory packagesDir;
   const groovyJavaIncompatabilityIndicator =
       'build.gradle must set an explicit Java compatibility version.';
+  const kotlinJavaIncompatabilityIndicator =
+      'build.gradle.kts must set an explicit Java compatibility version.';
 
   setUp(() {
     final GitDir gitDir;
@@ -128,6 +130,101 @@ dependencies {
 ''');
   }
 
+  /// Writes a fake android/build.gradle.kts file for plugin [package] with the
+  /// given options.
+  void writeFakeKotlinPluginBuildGradle(
+    RepositoryPackage package, {
+    bool includeLanguageVersion = false,
+    bool includeSourceCompat = false,
+    bool includeTargetCompat = false,
+    bool commentSourceLanguage = false,
+    bool includeNamespace = true,
+    bool commentNamespace = false,
+    bool warningsConfigured = true,
+    String compileSdk = '36',
+    bool includeKotlinOptions = true,
+    bool commentKotlinOptions = false,
+    bool useDeprecatedJvmTargetStyle = false,
+    int jvmTargetValue = 17,
+    int kotlinJvmValue = 17,
+  }) {
+    final File buildGradle = package
+        .platformDirectory(FlutterPlatform.android)
+        .childFile('build.gradle.kts');
+    buildGradle.createSync(recursive: true);
+
+    const warningConfig = '''
+    lint {
+        checkAllWarnings = true
+        warningsAsErrors = true
+        disable.addAll(setOf("AndroidGradlePluginVersion", "InvalidPackage", "GradleDependency", "NewerVersionAvailable"))
+        baseline = file("lint-baseline.xml")
+    }
+''';
+    final javaSection =
+        '''
+java {
+    toolchain {
+        ${commentSourceLanguage ? '// ' : ''}languageVersion = JavaLanguageVersion.of(8)
+    }
+}
+
+''';
+    final sourceCompat =
+        '${commentSourceLanguage ? '// ' : ''}sourceCompatibility = JavaVersion.VERSION_$jvmTargetValue';
+    final targetCompat =
+        '${commentSourceLanguage ? '// ' : ''}targetCompatibility = JavaVersion.VERSION_$jvmTargetValue';
+    final namespace =
+        '    ${commentNamespace ? '// ' : ''}namespace = "$_defaultFakeNamespace"';
+    final kotlinJvmTarget = useDeprecatedJvmTargetStyle
+        ? '$jvmTargetValue'
+        : 'JavaVersion.VERSION_$kotlinJvmValue.toString()';
+    final kotlinConfig =
+        '''
+    ${commentKotlinOptions ? '//' : ''}kotlinOptions {
+        ${commentKotlinOptions ? '//' : ''}jvmTarget = $kotlinJvmTarget
+    ${commentKotlinOptions ? '//' : ''}}''';
+
+    buildGradle.writeAsStringSync('''
+group = "dev.flutter.plugins.fake"
+version = "1.0-SNAPSHOT"
+
+buildscript {
+    repositories {
+        google()
+        mavenCentral()
+    }
+}
+
+apply plugin: 'com.android.library'
+
+${includeLanguageVersion ? javaSection : ''}
+android {
+${includeNamespace ? namespace : ''}
+    compileSdk = $compileSdk
+
+    defaultConfig {
+        minSdk = 30
+    }
+${warningsConfigured ? warningConfig : ''}
+    compileOptions {
+        ${includeSourceCompat ? sourceCompat : ''}
+        ${includeTargetCompat ? targetCompat : ''}
+    }
+    ${includeKotlinOptions ? kotlinConfig : ''}
+    testOptions {
+        unitTests {
+            isIncludeAndroidResources = true
+        }
+    }
+}
+
+dependencies {
+    implementation("fake.package:fake:1.0.0")
+}
+''');
+  }
+
   /// Writes a fake android/build.gradle file for an example [package] with the
   /// given options.
   // TODO(stuartmorgan): Once all packages are migrated to Kotlin, remove all
@@ -542,32 +639,65 @@ flutter {
     );
   });
 
-  test('fails when build.gradle has no java compatibility version', () async {
-    final RepositoryPackage package = createFakePlugin(
-      'a_plugin',
-      packagesDir,
-      examples: <String>[],
-    );
-    writeFakeGroovyPluginBuildGradle(package);
-    writeFakeManifest(package);
+  test(
+    'fails when build.gradle has no java compatibility version - groovy',
+    () async {
+      final RepositoryPackage package = createFakePlugin(
+        'a_plugin',
+        packagesDir,
+        examples: <String>[],
+      );
+      writeFakeGroovyPluginBuildGradle(package);
+      writeFakeManifest(package);
 
-    Error? commandError;
-    final List<String> output = await runCapturingPrint(
-      runner,
-      <String>['gradle-check'],
-      errorHandler: (Error e) {
-        commandError = e;
-      },
-    );
+      Error? commandError;
+      final List<String> output = await runCapturingPrint(
+        runner,
+        <String>['gradle-check'],
+        errorHandler: (Error e) {
+          commandError = e;
+        },
+      );
 
-    expect(commandError, isA<ToolExit>());
-    expect(
-      output,
-      containsAllInOrder(<Matcher>[
-        contains(groovyJavaIncompatabilityIndicator),
-      ]),
-    );
-  });
+      expect(commandError, isA<ToolExit>());
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains(groovyJavaIncompatabilityIndicator),
+        ]),
+      );
+    },
+  );
+
+  test(
+    'fails when build.gradle has no java compatibility version - kotlin',
+    () async {
+      final RepositoryPackage package = createFakePlugin(
+        'a_plugin',
+        packagesDir,
+        examples: <String>[],
+      );
+      writeFakeKotlinPluginBuildGradle(package);
+      writeFakeManifest(package);
+
+      Error? commandError;
+      final List<String> output = await runCapturingPrint(
+        runner,
+        <String>['gradle-check'],
+        errorHandler: (Error e) {
+          commandError = e;
+        },
+      );
+
+      expect(commandError, isA<ToolExit>());
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains(kotlinJavaIncompatabilityIndicator),
+        ]),
+      );
+    },
+  );
 
   test(
     'fails when sourceCompatibility is provided with out targetCompatibility',
@@ -774,7 +904,7 @@ flutter {
   test('does not require java version in examples - kotlin', () async {
     const pluginName = 'a_plugin';
     final RepositoryPackage package = createFakePlugin(pluginName, packagesDir);
-    writeFakeGroovyPluginBuildGradle(package, includeLanguageVersion: true);
+    writeFakeKotlinPluginBuildGradle(package, includeLanguageVersion: true);
     writeFakeManifest(package);
     final RepositoryPackage example = package.getExamples().first;
     writeFakeKotlinExampleBuildGradles(example, pluginName: pluginName);
@@ -888,7 +1018,7 @@ flutter {
     },
   );
 
-  test('fails when namespace is missing', () async {
+  test('fails when namespace is missing - groovy', () async {
     final RepositoryPackage package = createFakePlugin(
       'a_plugin',
       packagesDir,
@@ -919,6 +1049,37 @@ flutter {
     );
   });
 
+  test('fails when namespace is missing - kotlin', () async {
+    final RepositoryPackage package = createFakePlugin(
+      'a_plugin',
+      packagesDir,
+      examples: <String>[],
+    );
+    writeFakeKotlinPluginBuildGradle(
+      package,
+      includeLanguageVersion: true,
+      includeNamespace: false,
+    );
+    writeFakeManifest(package);
+
+    Error? commandError;
+    final List<String> output = await runCapturingPrint(
+      runner,
+      <String>['gradle-check'],
+      errorHandler: (Error e) {
+        commandError = e;
+      },
+    );
+
+    expect(commandError, isA<ToolExit>());
+    expect(
+      output,
+      containsAllInOrder(<Matcher>[
+        contains('build.gradle.kts must set a "namespace"'),
+      ]),
+    );
+  });
+
   test('fails when namespace is missing from example - groovy', () async {
     const pluginName = 'a_plugin';
     final RepositoryPackage package = createFakePlugin(pluginName, packagesDir);
@@ -953,7 +1114,7 @@ flutter {
   test('fails when namespace is missing from example - kotlin', () async {
     const pluginName = 'a_plugin';
     final RepositoryPackage package = createFakePlugin(pluginName, packagesDir);
-    writeFakeGroovyPluginBuildGradle(package, includeLanguageVersion: true);
+    writeFakeKotlinPluginBuildGradle(package, includeLanguageVersion: true);
     writeFakeManifest(package);
     final RepositoryPackage example = package.getExamples().first;
     writeFakeKotlinExampleBuildGradles(
