refactor(model): re-implement seed to use new API

Author: mkumbobeaty

examples/app.js

@@ -1,8 +1,6 @@
 'use strict';
 
 /* dependencies */
-const path = require('path');
-const async = require('async');
 const { include } = require('@lykmapipo/include');
 const { connect } = require('@lykmapipo/mongoose-common');
 const { get, start, mount } = require('@lykmapipo/express-common');

lib/feature.model.js

@@ -22,11 +22,9 @@
  */
 
 /* dependencies */
-const path = require('path');
 const _ = require('lodash');
-const { parallel, waterfall } = require('async');
 const { getString } = require('@lykmapipo/env');
-const { Schema, model, SCHEMA_OPTIONS } = require('@lykmapipo/mongoose-common');
+const { Schema, model, SCHEMA_OPTIONS, copyInstance } = require('@lykmapipo/mongoose-common');
 const { Point, Geometry, centroidOf } = require('mongoose-geojson-schemas');
 const {
   CONTINENT_NAMES,
@@ -50,7 +48,6 @@ const FEATURE_COLLECTION_NAME = getString(
   'FEATURE_COLLECTION_NAME',
   'features'
 );
-const FEATURE_SEED = getString('FEATURE_SEED', 'features');
 
 /**
  * @name FeatureSchema
@@ -444,106 +441,31 @@ FeatureSchema.statics.CONTINENTS = CONTINENT_NAMES;
 FeatureSchema.statics.DEFAULT_COUNTRY_NAME = DEFAULT_COUNTRY_NAME;
 FeatureSchema.statics.COUNTRIES = COUNTRY_NAMES;
 
+
 /**
- * @name upsert
- * @function upsert
- * @description create or update existing feature
- * @param {Object} feature valid feature details
- * @param {Function} done callback to invoke on success or error
+ * @name prepareSeedCriteria
+ * @function prepareSeedCriteria
+ * @description prepare feature seeding upsert criteria
+ * @param {Object} seed plain object feature seed
+ * @return {Object} criteria used to upsert feature
  *
  * @author lally elias <lallyelias87@gmail.com>
- * @since 1.0.0
+ * @since 1.5.0
  * @version 0.1.0
  * @public
  */
-FeatureSchema.statics.upsert = function upsert(feature, done) {
-  //normalize arguments
-  let _feature = _.isFunction(feature.toObject) ? feature.toObject() : feature;
-
-  //refs
-  const Feature = this;
-
-  // prepare upsert
-  waterfall(
-    [
-      function findExistingFeature(next) {
-        // prepare criteria by _id or fields
-        let criteria = _.merge({}, _feature);
-        /* jshint ignore:start */
-        criteria = criteria._id
-          ? _.pick(criteria, '_id')
-          : _.pick(criteria, 'nature', 'family', 'type', 'name');
-        /* jshint ignore:end */
-        Feature.findOne(criteria, next);
-      },
-
-      function upsertFeature(found, next) {
-        // instantiate if not found
-        if (!found) {
-          found = new Feature(_feature);
-        }
-
-        // prepare updates
-        _feature = _.merge({}, _feature, found.toObject());
-
-        // do upsert
-        found.updatedAt = new Date();
-        found.put(_feature, next);
-      },
-    ],
-    done
+FeatureSchema.statics.prepareSeedCriteria = seed => {
+  // prepare feature upsert criteria by _id or fields
+  let criteria = copyInstance(seed);
+  criteria = (
+    criteria._id ?
+     _.pick(criteria, '_id') : 
+     _.pick(criteria, 'nature', 'family', 'type', 'name')
   );
+  // return feature upsert criteria
+  return criteria;
 };
 
-/**
- * @name seed
- * @function seed
- * @description seed features into database, on duplicate existing wins
- * on merging.
- * @param {Feature[]} [features] set of feature(s) to seed
- * @param {Function} done callback to invoke on success or error
- *
- * @author lally elias <lallyelias87@gmail.com>
- * @since 1.0.0
- * @version 0.1.0
- * @public
- */
-FeatureSchema.statics.seed = function seed(seeds, done) {
-  // normalize arguments
-  let _seeds = _.isFunction(seeds) ? [] : [].concat(seeds);
-  const _done = _.isFunction(seeds) ? seeds : done;
-
-  // refs
-  const Feature = this;
-
-  // init features collection
-  let features = [];
-
-  // try load seeds from environment
-  const BASE_PATH = getString('BASE_PATH', process.cwd());
-  const SEEDS_PATH = getString('SEEDS_PATH', path.join(BASE_PATH, 'seeds'));
-  const SEED_PATH = path.join(SEEDS_PATH, FEATURE_SEED);
-  try {
-    const seed = require(SEED_PATH);
-    _seeds = [].concat(_seeds).concat(seed);
-  } catch (e) {
-    /* ignore */
-  }
-
-  // collect unique feature from seeds
-  _seeds = _.compact(_seeds);
-  _seeds = _.uniqWith(_seeds, _.isEqual);
-
-  // upsert features
-  features = _.map([].concat(_seeds), function(feature) {
-    return function upsertFeatures(next) {
-      Feature.upsert(feature, next);
-    };
-  });
-
-  // seed features
-  parallel(features, _done);
-};
 
 /*
  *------------------------------------------------------------------------------